Mojo: mojob.sh: Make --release (etc.) work properly again.

mojo/tools/mojob.sh

 #!/bin/bash
 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # This a simple script to make building/testing Mojo components easier (on
 # Linux).
 
 # TODO(vtl): Maybe make the test runner smart and not run unchanged test
 # binaries.
@@ skipping 83 matching lines @@
 should_do_Release() {
   test "$BUILD_TYPE" = Release -o "$BUILD_TYPE" = Debug_and_Release
 }
 
 # Valid values: clang or gcc.
 COMPILER=clang
 # Valid values: auto or disabled.
 GOMA=auto
 make_gn_args() {
   local args=()
+  # TODO(vtl): It's a bit of a hack to infer the build type from the output
+  # directory name, but it's what we have right now (since we support "debug and
+  # release" mode).
+  case "$1" in
+    Debug)
+      # (Default.)
+      ;;
+    Release)
+      args+=("is_debug=false")

[jamesr, 2014/10/21 01:21:11]

just need an 'if' here and not a case, right?

+      ;;
+  esac
   case "$COMPILER" in
     clang)
-      args+=("is_clang=true")
+      # (Default.)

[jamesr, 2014/10/21 01:21:11]

we can change the default of clang - my comment was *only* about is_debug, which
I dont' think we will ever be able to change in the GN configuration

       ;;
     gcc)
       args+=("is_clang=false")
       ;;
   esac
   case "$GOMA" in
     auto)
       if [ -v GOMA_DIR ]; then
         args+=("use_goma=true" "goma_dir=\"${GOMA_DIR}\"")
       elif [ -d "${HOME}/goma" ]; then
         args+=("use_goma=true" "goma_dir=\"${HOME}/goma\"")
       else

[jamesr, 2014/10/21 01:21:11]

can just get rid of this branch, no?

-        args+=("use_goma=false")
+        # (Default.)
       fi
       ;;
     disabled)

[jamesr, 2014/10/21 01:21:11]

and get rid of this and simplify the 'case' to just an if ?

-      args+=("use_goma=false")
+      # (Default.)
       ;;
   esac
   echo "${args[*]}"
 }
 
 # We're in src/mojo/tools. We want to get to src.
 cd "$(realpath "$(dirname "$0")")/../.."
 
 if [ $# -eq 0 ]; then
   do_help
@@ skipping 62 matching lines @@
       GOMA=disabled
       ;;
     *)
       echo "Unknown command \"${arg}\". Try \"$(basename "$0") help\"."
       exit 1
       ;;
   esac
 done
 
 exit 0