Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 663023005: [Telemetry] Add file handle & trace value. (Closed)

Created:
6 years, 2 months ago by nednguyen
Modified:
6 years, 1 month ago
Reviewers:
achuithb, dtu, chrishenry, nduca
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Add file handle & trace value. Modify json_output_formatter to include trace values in the result output. This is a partial land of Ethan's patch in https://codereview.chromium.org/545523002/. BUG= Committed: https://crrev.com/d239c1bec380fd3efd779e755caf9caf25fe154f Cr-Commit-Position: refs/heads/master@{#301558}

Patch Set 1 : #

Patch Set 2 : Ready to land ^^ #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+338 lines, -32 lines) Patch
M tools/perf/measurements/smoothness_controller.py View 3 chunks +4 lines, -2 lines 1 comment Download
M tools/telemetry/telemetry/results/json_output_formatter.py View 2 chunks +26 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/results/json_output_formatter_unittest.py View 6 chunks +34 lines, -5 lines 0 comments Download
M tools/telemetry/telemetry/results/page_test_results.py View 2 chunks +8 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/results/results_options.py View 1 chunk +1 line, -1 line 0 comments Download
A tools/telemetry/telemetry/util/file_handle.py View 1 1 chunk +100 lines, -0 lines 0 comments Download
A tools/telemetry/telemetry/util/file_handle_unittest.py View 1 1 chunk +47 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/value/__init__.py View 1 chunk +4 lines, -0 lines 0 comments Download
A tools/telemetry/telemetry/value/trace.py View 1 1 chunk +79 lines, -0 lines 1 comment Download
A tools/telemetry/telemetry/value/trace_unittest.py View 1 chunk +31 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/timeline_based_measurement.py View 3 chunks +3 lines, -20 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
nednguyen
6 years, 1 month ago (2014-10-27 20:46:49 UTC) #3
nduca
lgtm and lets iterate
6 years, 1 month ago (2014-10-28 00:02:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/663023005/60001
6 years, 1 month ago (2014-10-28 02:38:42 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:60001)
6 years, 1 month ago (2014-10-28 03:53:23 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/d239c1bec380fd3efd779e755caf9caf25fe154f Cr-Commit-Position: refs/heads/master@{#301558}
6 years, 1 month ago (2014-10-28 03:54:04 UTC) #9
achuithb
6 years, 1 month ago (2014-11-20 21:40:50 UTC) #11
Message was sent while issue was closed. 
https://codereview.chromium.org/663023005/diff/60001/tools/perf/measurements/...
File tools/perf/measurements/smoothness_controller.py (right):

https://codereview.chromium.org/663023005/diff/60001/tools/perf/measurements/...
tools/perf/measurements/smoothness_controller.py:60: # End the smooth marker for
 all smooth actions.
nit: remove extra space

https://codereview.chromium.org/663023005/diff/60001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/value/trace.py (right):

https://codereview.chromium.org/663023005/diff/60001/tools/telemetry/telemetr...
tools/telemetry/telemetry/value/trace.py:26: tf =
tempfile.NamedTemporaryFile(delete=False, suffix='.html')
Is this file cleaned up?

Powered by Google App Engine
This is Rietveld 408576698