[Telemetry] Add file handle & trace value.

tools/perf/measurements/smoothness_controller.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 import sys
 
 from measurements import smooth_gesture_util
 from telemetry.core.platform import tracing_category_filter
 from telemetry.core.platform import tracing_options
 from telemetry.timeline.model import TimelineModel
 from telemetry.page import page_test
 from telemetry.page.actions import action_runner
 from telemetry.value import list_of_scalar_values
 from telemetry.value import scalar
+from telemetry.value import trace
 from telemetry.web_perf import timeline_interaction_record as tir_module
 from telemetry.web_perf.metrics import smoothness
 
 
 RUN_SMOOTH_ACTIONS = 'RunSmoothAllActions'
 
 # Descriptions for results from platform.GetRawDisplayFrameRateMeasurements().
 DESCRIPTIONS = {
     'avg_surface_fps': 'Average frames per second as measured by the '
                        'platform\'s SurfaceFlinger.'
@@ skipping 25 matching lines @@
     if tab.browser.platform.IsRawDisplayFrameRateSupported():
       tab.browser.platform.StartRawDisplayFrameRateMeasurement()
 
   def Start(self, tab):
     # Start the smooth marker for all smooth actions.
     runner = action_runner.ActionRunner(tab)
     self._interaction = runner.BeginInteraction(
         RUN_SMOOTH_ACTIONS, is_smooth=True)
 
   def Stop(self, tab):
-    # End the smooth marker for all smooth actions.
+    # End the smooth marker for  all smooth actions.

[achuithb, 2014/11/20 21:40:50]

nit: remove extra space

     self._interaction.End()
     # Stop tracing for smoothness metric.
     if tab.browser.platform.IsRawDisplayFrameRateSupported():
       tab.browser.platform.StopRawDisplayFrameRateMeasurement()
     self._tracing_timeline_data = tab.browser.platform.tracing_controller.Stop()
     self._timeline_model = TimelineModel(
       timeline_data=self._tracing_timeline_data)
 
   def AddResults(self, tab, results):
     # Add results of smoothness metric. This computes the smoothness metric for
     # the time ranges of gestures, if there is at least one, else the the time
     # ranges from the first action to the last action.
-
+    results.AddValue(trace.TraceValue(
+        results.current_page, self._tracing_timeline_data))
     renderer_thread = self._timeline_model.GetRendererThreadFromTabId(
         tab.id)
     run_smooth_actions_record = None
     smooth_records = []
     for event in renderer_thread.async_slices:
       if not tir_module.IsTimelineInteractionRecord(event.name):
         continue
       r = tir_module.TimelineInteractionRecord.FromAsyncEvent(event)
       if r.label == RUN_SMOOTH_ACTIONS:
         assert run_smooth_actions_record is None, (
@@ skipping 36 matching lines @@
         else:
           results.AddValue(scalar.ScalarValue(
               results.current_page, r.name, r.unit, r.value,
               description=DESCRIPTIONS.get(r.name)))
 
   def CleanUp(self, tab):
     if tab.browser.platform.IsRawDisplayFrameRateSupported():
       tab.browser.platform.StopRawDisplayFrameRateMeasurement()
     if tab.browser.platform.tracing_controller.is_tracing_running:
       tab.browser.platform.tracing_controller.Stop()