Issue 663013003: Removing QUIC_VERSION_18.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 663013003: Removing QUIC_VERSION_18. (Closed)

Created:
6 years, 2 months ago by ramant (doing other things)

Modified:
6 years, 2 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@Change_QUIC_pacing_granularity_77587738

Project:
chromium

Visibility:
Public.

More Reviews

Description

Removing QUIC_VERSION_18. This also lets us remove the code for -hard-coded session limits, since those apply to v19 or greater -stats tracking % sessions with no flow control -the bulk of AdjustErrorForVersion since there's no outstanding versions with new errors Removing QUIC_VERSION_18. Not flag protected. Merge internal change: 77603158 R=rch@chromium.org

Patch Set 1 #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -273 lines)			Patch
M	net/quic/quic_connection_test.cc	View	2 chunks	+1 line, -17 lines	0 comments	Download
M	net/quic/quic_data_stream_test.cc	View	2 chunks	+0 lines, -6 lines	0 comments	Download
M	net/quic/quic_framer_test.cc	View	1 chunk	+6 lines, -14 lines	0 comments	Download
M	net/quic/quic_protocol.h	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	net/quic/quic_protocol.cc	View	3 chunks	+0 lines, -12 lines	0 comments	Download
M	net/quic/quic_protocol_test.cc	View	1 chunk	+5 lines, -3 lines	0 comments	Download
M	net/quic/quic_session.cc	View	3 chunks	+3 lines, -7 lines	0 comments	Download
M	net/quic/quic_session_test.cc	View	5 chunks	+1 line, -207 lines	0 comments	Download
M	net/tools/quic/end_to_end_test.cc	View	2 chunks	+1 line, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages