net/quic/quic_protocol_test.cc - Issue 663013003: Removing QUIC_VERSION_18.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_protocol_test.cc

Issue 663013003: Removing QUIC_VERSION_18. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Change_QUIC_pacing_granularity_77587738

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/quic_protocol_test.cc

diff --git a/net/quic/quic_protocol_test.cc b/net/quic/quic_protocol_test.cc

index 4f234908c72b71813239804ed4840560ada55c13..43a009ab85c424e6c2750e4150018df589a5f002 100644

--- a/net/quic/quic_protocol_test.cc

+++ b/net/quic/quic_protocol_test.cc

@@ -16,9 +16,11 @@ TEST(QuicProtocolTest, AdjustErrorForVersion) {

<< "Any additions to QuicRstStreamErrorCode require an addition to "

<< "AdjustErrorForVersion and this associated test.";

- EXPECT_EQ(QUIC_RST_FLOW_CONTROL_ACCOUNTING, AdjustErrorForVersion(

- QUIC_RST_FLOW_CONTROL_ACCOUNTING,

- QUIC_VERSION_18));

+ // If we ever add different RST codes, we should have a test akin to the

+ // following.

+ // EXPECT_EQ(QUIC_RST_FLOW_CONTROL_ACCOUNTING, AdjustErrorForVersion(

+ // QUIC_RST_FLOW_CONTROL_ACCOUNTING,

+ // QUIC_VERSION_18));

}

TEST(QuicProtocolTest, MakeQuicTag) {

« no previous file with comments | « net/quic/quic_protocol.cc ('k') | net/quic/quic_session.cc » ('j') | no next file with comments »