drive: Add drive/trash

drive: Add drive/trash

This directory is used to hold locally deleted entries which are waiting for server side deletion.

BUG=260542
TEST=unit_tests

[kinaba, 2013-11-12 02:10:26]

https://codereview.chromium.org/66293005/diff/130001/chrome/browser/chromeos/...
File chrome/browser/chromeos/drive/file_system_util.h (right):

https://codereview.chromium.org/66293005/diff/130001/chrome/browser/chromeos/...
chrome/browser/chromeos/drive/file_system_util.h:89: bool
IsSpecialResourceId(const std::string& resource_id);
I guess this functions should handle <trash> as a special ID.

https://codereview.chromium.org/66293005/diff/130001/chrome/browser/chromeos/...
chrome/browser/chromeos/drive/file_system_util.h:89: bool
IsSpecialResourceId(const std::string& resource_id);
And about "not supposed to be sent to the server",
ChangeListLoader::DoLoadDirectoryFromServer
is filtering directory load request to <other>
Probably we might want to handle <trash> there as well, by using this utility
function.

https://codereview.chromium.org/66293005/diff/130001/chrome/browser/chromeos/...
File chrome/browser/chromeos/drive/search_metadata.cc (right):

https://codereview.chromium.org/66293005/diff/130001/chrome/browser/chromeos/...
chrome/browser/chromeos/drive/search_metadata.cc:125: entry.parent_local_id() ==
util::kDriveTrashDirLocalId) {
Is looking only the parent sufficient (i.e., what happens if the user removed a
directory?)

[hashimoto, 2013-11-12 04:08:12]

https://codereview.chromium.org/66293005/diff/130001/chrome/browser/chromeos/...
File chrome/browser/chromeos/drive/file_system_util.h (right):

https://codereview.chromium.org/66293005/diff/130001/chrome/browser/chromeos/...
chrome/browser/chromeos/drive/file_system_util.h:89: bool
IsSpecialResourceId(const std::string& resource_id);
On 2013/11/12 02:10:27, kinaba wrote:
> And about "not supposed to be sent to the server",
> ChangeListLoader::DoLoadDirectoryFromServer
> is filtering directory load request to <other>
> Probably we might want to handle <trash> there as well, by using this utility
> function.
We shouldn't handle kDriveTrashDirId with this function because
kDriveTrashDirLocalId is not used as a resource ID. (resource_id of drive/trash
is empty)
Hence there is no chance for <trash> to be handled by ChangeListLoader.

Removed a wrong use of IsSpecialResourceId in ResourceMetadata::RemoveEntry.

https://codereview.chromium.org/66293005/diff/130001/chrome/browser/chromeos/...
File chrome/browser/chromeos/drive/search_metadata.cc (right):

https://codereview.chromium.org/66293005/diff/130001/chrome/browser/chromeos/...
chrome/browser/chromeos/drive/search_metadata.cc:125: entry.parent_local_id() ==
util::kDriveTrashDirLocalId) {
On 2013/11/12 02:10:27, kinaba wrote:
> Is looking only the parent sufficient (i.e., what happens if the user removed
a
> directory?)

Hmm, recursively looking up parent does not look efficient.
Maybe we should use a boolean flag for deleted entries instead of drive/trash...

[hashimoto, 2013-11-12 05:56:31]

Chatted with kinaba offline.
Recursively checking parent ID from SearchMetadata will make it very slow.
Using ResourceEntry::deleted() to distinguish locally deleted entries results in
some complexity. (GetResourceEntry should return deleted entries or not?)

Will use drive/other to store deleted entries, while using
ResourceEntry::deleted() to filter out them from search result.
Closing this issue.