url/url_canon.h - Issue 662713004: Type conversion fixes, url/ edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: url/url_canon.h

Issue 662713004: Type conversion fixes, url/ edition. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: url/url_canon.h

diff --git a/url/url_canon.h b/url/url_canon.h

index 624eeaf4710a3bedaadcb606eb43c80167f08a9e..8bf7bb73877ae363dcb382440574f9066e762099 100644

--- a/url/url_canon.h

+++ b/url/url_canon.h

@@ -47,7 +47,7 @@ class CanonOutputT {

// Sets the character at the given position. The given position MUST be less

// than the length().

- inline void set(int offset, int ch) {

+ inline void set(int offset, char ch) {

brettw 2014/10/17 17:31:17 This should be "T" instead of char. Can you fix th

Peter Kasting 2014/10/17 22:49:07 Done.

buffer_[offset] = ch;

}

« no previous file with comments | « no previous file | url/url_canon_fileurl.cc » ('j') | no next file with comments »