Include file required for Chromoting browser-tests in output of chromoting-integration specific bui…

Copy test-accounts file from src-internal to build output dir.

BUG=424376
Committed: https://crrev.com/59c6ceab69b43af08cd3ffac0896410e9b9589ad
Cr-Commit-Position: refs/heads/master@{#300106}

[anandc, 2014-10-16 22:16:37]

anandc@chromium.org changed reviewers:
+ maruel@chromium.org

[anandc, 2014-10-16 22:26:26]

Hi M-A, could you please take a look?
I've restricted visibility of this CL, considering it relates to src-internal
work.
Thank you.

https://codereview.chromium.org/662713002/diff/1/testing/chromoting/integrati...
File testing/chromoting/integration_tests.gyp (right):

https://codereview.chromium.org/662713002/diff/1/testing/chromoting/integrati...
testing/chromoting/integration_tests.gyp:7: ['archive_chromoting_tests==1', {
Only if this gyp property is set will we attempt to copy the test-accounts file
from src-internal to the build output folder.

This should prevent the copy to be attempted for regular/official builds.

https://codereview.chromium.org/662713002/diff/1/testing/chromoting/integrati...
testing/chromoting/integration_tests.gyp:39: ],
When this action is performed, the file containing test accounts information is
included in the build target.
Longer term, we want to get this information from GCS (see bug:
https://code.google.com/p/chromium/issues/detail?id=424381)

For now, the Chromoting bot
(http://chromegw.corp.google.com/i/internal.chromoting/waterfall) is the only
known waterfall where archive_chromoting_tests is set. 

Are builds from that waterfall archived some place? If so, are those archives
locked down? We'd like to make sure those builds are only accessible to
Googlers.

[M-A Ruel, 2014-10-16 22:38:04]

lgtm

https://codereview.chromium.org/662713002/diff/1/testing/chromoting/integrati...
File testing/chromoting/integration_tests.gyp (right):

https://codereview.chromium.org/662713002/diff/1/testing/chromoting/integrati...
testing/chromoting/integration_tests.gyp:7: ['archive_chromoting_tests==1', {
On 2014/10/16 22:26:26, anandc wrote:
> Only if this gyp property is set will we attempt to copy the test-accounts
file
> from src-internal to the build output folder.
> 
> This should prevent the copy to be attempted for regular/official builds.

Perfect.

https://codereview.chromium.org/662713002/diff/1/testing/chromoting/integrati...
testing/chromoting/integration_tests.gyp:39: ],
On 2014/10/16 22:26:26, anandc wrote:
> When this action is performed, the file containing test accounts information
is
> included in the build target.
> Longer term, we want to get this information from GCS (see bug:
> https://code.google.com/p/chromium/issues/detail?id=424381)
> 
> For now, the Chromoting bot
> (http://chromegw.corp.google.com/i/internal.chromoting/waterfall) is the only
> known waterfall where archive_chromoting_tests is set. 
> 
> Are builds from that waterfall archived some place? If so, are those archives
> locked down? We'd like to make sure those builds are only accessible to
> Googlers.

No idea, sorry.

[anandc, 2014-10-16 22:54:50]

anandc@chromium.org changed reviewers:
+ leilei@chromium.org, weitaosu@chromium.org
- maruel@chromium.org

[anandc, 2014-10-16 22:54:51]

Thanks M-A. Moved you to CC.

Lei: could you please answer the question I ask in my 2nd comment?

+Weitao to Reviewers list.

[Lei Lei, 2014-10-16 23:45:25]

https://codereview.chromium.org/662713002/diff/1/testing/chromoting/integrati...
File testing/chromoting/integration_tests.gyp (right):

https://codereview.chromium.org/662713002/diff/1/testing/chromoting/integrati...
testing/chromoting/integration_tests.gyp:39: ],
On 2014/10/16 22:26:26, anandc wrote:
> When this action is performed, the file containing test accounts information
is
> included in the build target.
> Longer term, we want to get this information from GCS (see bug:
> https://code.google.com/p/chromium/issues/detail?id=424381)
> 
> For now, the Chromoting bot
> (http://chromegw.corp.google.com/i/internal.chromoting/waterfall) is the only
> known waterfall where archive_chromoting_tests is set. 
> 
> Are builds from that waterfall archived some place? If so, are those archives
> locked down? We'd like to make sure those builds are only accessible to
> Googlers.

Why do you need to copy it? Does it work if just add this file in dependency
files using relative path? Since archiving is triggered after gclient sync.

The builds will be archived to isolate server and the builds could be downloaded
from any swarming slaves. And it is only open to all googlers.

[M-A Ruel, 2014-10-16 23:47:06]

maruel@chromium.org changed reviewers:
+ maruel@chromium.org

[M-A Ruel, 2014-10-16 23:47:07]

https://codereview.chromium.org/662713002/diff/1/testing/chromoting/integrati...
File testing/chromoting/integration_tests.gyp (right):

https://codereview.chromium.org/662713002/diff/1/testing/chromoting/integrati...
testing/chromoting/integration_tests.gyp:39: ],
On 2014/10/16 23:45:24, Lei Lei wrote:
> On 2014/10/16 22:26:26, anandc wrote:
> > When this action is performed, the file containing test accounts information
> is
> > included in the build target.
> > Longer term, we want to get this information from GCS (see bug:
> > https://code.google.com/p/chromium/issues/detail?id=424381)
> > 
> > For now, the Chromoting bot
> > (http://chromegw.corp.google.com/i/internal.chromoting/waterfall) is the
only
> > known waterfall where archive_chromoting_tests is set. 
> > 
> > Are builds from that waterfall archived some place? If so, are those
archives
> > locked down? We'd like to make sure those builds are only accessible to
> > Googlers.
> 
> Why do you need to copy it? Does it work if just add this file in dependency
> files using relative path? Since archiving is triggered after gclient sync.
> 
> The builds will be archived to isolate server and the builds could be
downloaded
> from any swarming slaves. And it is only open to all googlers.

Strictly speaking, this is true. I personally don't mind.

[anandc, 2014-10-17 01:00:54]

anandc@chromium.org changed reviewers:
- maruel@chromium.org

[anandc, 2014-10-17 01:00:54]

Thanks. The latest patch set, #2, adds a dependency to this file, and I tested
it works.

Weitao, PTAL. Thank you.

https://codereview.chromium.org/662713002/diff/1/testing/chromoting/integrati...
File testing/chromoting/integration_tests.gyp (right):

https://codereview.chromium.org/662713002/diff/1/testing/chromoting/integrati...
testing/chromoting/integration_tests.gyp:39: ],
On 2014/10/16 23:45:24, Lei Lei wrote:
> On 2014/10/16 22:26:26, anandc wrote:
> > When this action is performed, the file containing test accounts information
> is
> > included in the build target.
> > Longer term, we want to get this information from GCS (see bug:
> > https://code.google.com/p/chromium/issues/detail?id=424381)
> > 
> > For now, the Chromoting bot
> > (http://chromegw.corp.google.com/i/internal.chromoting/waterfall) is the
only
> > known waterfall where archive_chromoting_tests is set. 
> > 
> > Are builds from that waterfall archived some place? If so, are those
archives
> > locked down? We'd like to make sure those builds are only accessible to
> > Googlers.
> 
> Why do you need to copy it? Does it work if just add this file in dependency
> files using relative path? Since archiving is triggered after gclient sync.
> 
> The builds will be archived to isolate server and the builds could be
downloaded
> from any swarming slaves. And it is only open to all googlers.

Done.

Thanks. Just tested this by running it on a swarming slave and downloading the
files from that instance:
https://chromium-swarm-dev.appspot.com/user/task/1491b9361df8a00
The test accounts file is placed under remoting/tools/internal, which is good.
(Wondering if there is a quicker way to check this, rather than having to first
run on a slave then download files for that execution? Is there a tmp folder
that it creates when this test is run locally with isolate.py run?)

https://codereview.chromium.org/662713002/diff/1/testing/chromoting/integrati...
testing/chromoting/integration_tests.gyp:39: ],
On 2014/10/16 23:47:07, M-A Ruel wrote:
> On 2014/10/16 23:45:24, Lei Lei wrote:
> > On 2014/10/16 22:26:26, anandc wrote:
> > > When this action is performed, the file containing test accounts
information
> > is
> > > included in the build target.
> > > Longer term, we want to get this information from GCS (see bug:
> > > https://code.google.com/p/chromium/issues/detail?id=424381)
> > > 
> > > For now, the Chromoting bot
> > > (http://chromegw.corp.google.com/i/internal.chromoting/waterfall) is the
> only
> > > known waterfall where archive_chromoting_tests is set. 
> > > 
> > > Are builds from that waterfall archived some place? If so, are those
> archives
> > > locked down? We'd like to make sure those builds are only accessible to
> > > Googlers.
> > 
> > Why do you need to copy it? Does it work if just add this file in dependency
> > files using relative path? Since archiving is triggered after gclient sync.
> > 
> > The builds will be archived to isolate server and the builds could be
> downloaded
> > from any swarming slaves. And it is only open to all googlers.
> 
> Strictly speaking, this is true. I personally don't mind.

Acknowledged.

[M-A Ruel, 2014-10-17 01:06:18]

On 2014/10/17 01:00:54, anandc wrote:
> Thanks. The latest patch set, #2, adds a dependency to this file, and I tested
> it works.

lgtm

> Thanks. Just tested this by running it on a swarming slave and downloading the
> files from that instance:
> https://chromium-swarm-dev.appspot.com/user/task/1491b9361df8a00
> The test accounts file is placed under remoting/tools/internal, which is good.
> (Wondering if there is a quicker way to check this, rather than having to
first
> run on a slave then download files for that execution? Is there a tmp folder
> that it creates when this test is run locally with isolate.py run?)

I don't understand what you mean. If you mean testing locally, you can use:
  isolate.py run -s out/Release/chromoting_integration_tests.isolated
you can also use the command remap. Use isolate.py --help for more details, then
help on each command.

[anandc, 2014-10-17 03:52:27]

On 2014/10/17 01:06:18, M-A Ruel wrote:
> On 2014/10/17 01:00:54, anandc wrote:
> > Thanks. The latest patch set, #2, adds a dependency to this file, and I
tested
> > it works.
> 
> lgtm
> 
> > Thanks. Just tested this by running it on a swarming slave and downloading
the
> > files from that instance:
> > https://chromium-swarm-dev.appspot.com/user/task/1491b9361df8a00
> > The test accounts file is placed under remoting/tools/internal, which is
good.
> > (Wondering if there is a quicker way to check this, rather than having to
> first
> > run on a slave then download files for that execution? Is there a tmp folder
> > that it creates when this test is run locally with isolate.py run?)
> 
> I don't understand what you mean. If you mean testing locally, you can use:
>   isolate.py run -s out/Release/chromoting_integration_tests.isolated
> you can also use the command remap. Use isolate.py --help for more details,
then
> help on each command.

Thanks. I think you answered it; I tried "isolate.py run" and it passed. I'll
look at remap as well.

Thanks again.

[Lei Lei, 2014-10-17 03:55:02]

lgtm

[anandc, 2014-10-17 13:52:18]

The CQ bit was checked by anandc@chromium.org

[commit-bot: I haz the power, 2014-10-17 13:52:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/662713002/20001

[commit-bot: I haz the power, 2014-10-17 14:53:54]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-10-17 14:54:40]

Patchset 2 (id:??) landed as
https://crrev.com/59c6ceab69b43af08cd3ffac0896410e9b9589ad
Cr-Commit-Position: refs/heads/master@{#300106}