Include file required for Chromoting browser-tests in output of chromoting-integration specific bui…

testing/chromoting/integration_tests.gyp

 # Copyright (c) 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'conditions': [
     ['archive_chromoting_tests==1', {

[anandc, 2014/10/16 22:26:26]

Only if this gyp property is set will we attempt to copy the test-accounts file
from src-internal to the build output folder.

This should prevent the copy to be attempted for regular/official builds.

[M-A Ruel, 2014/10/16 22:38:04]

Perfect.

       'targets': [
         {
           'target_name': 'chromoting_integration_tests_run',
           'type': 'none',
           'dependencies': [
             '../../chrome/chrome.gyp:browser_tests',
             '../../remoting/remoting.gyp:remoting_webapp_v1',
             '../../remoting/remoting.gyp:remoting_webapp_v2',
           ],
           'includes': [
             '../../build/isolate.gypi',
           ],
           'sources': [
             'chromoting_integration_tests.isolate',
           ],
+          'actions': [
+            {
+              'action_name': 'Copy system module.',
+              'inputs': [
+                '<(DEPTH)/build/cp.py',
+                '../../remoting/tools/internal/test_accounts.json',
+              ],
+              'outputs': [
+                '<(PRODUCT_DIR)/test_accounts.json',
+              ],
+              'action': [
+                'python',
+                '<@(_inputs)',
+                '<@(_outputs)',
+              ]
+            },
+          ],

[anandc, 2014/10/16 22:26:26]

When this action is performed, the file containing test accounts information is
included in the build target.
Longer term, we want to get this information from GCS (see bug:
https://code.google.com/p/chromium/issues/detail?id=424381)

For now, the Chromoting bot
(http://chromegw.corp.google.com/i/internal.chromoting/waterfall) is the only
known waterfall where archive_chromoting_tests is set. 

Are builds from that waterfall archived some place? If so, are those archives
locked down? We'd like to make sure those builds are only accessible to
Googlers.

[M-A Ruel, 2014/10/16 22:38:04]

No idea, sorry.

[Lei Lei, 2014/10/16 23:45:24]

Why do you need to copy it? Does it work if just add this file in dependency
files using relative path? Since archiving is triggered after gclient sync.

The builds will be archived to isolate server and the builds could be downloaded
from any swarming slaves. And it is only open to all googlers.

[M-A Ruel, 2014/10/16 23:47:07]

Strictly speaking, this is true. I personally don't mind.

[anandc, 2014/10/17 01:00:54]

Done.

Thanks. Just tested this by running it on a swarming slave and downloading the
files from that instance:
https://chromium-swarm-dev.appspot.com/user/task/1491b9361df8a00
The test accounts file is placed under remoting/tools/internal, which is good.
(Wondering if there is a quicker way to check this, rather than having to first
run on a slave then download files for that execution? Is there a tmp folder
that it creates when this test is run locally with isolate.py run?)

[anandc, 2014/10/17 01:00:54]

Acknowledged.

         },
       ],
     }],
   ],
 }