CHROMIUM: Board file changes for Tegra camera

CHROMIUM: Board file changes for Tegra camera

This patch adds support for V4L2 camera on Seaboard and Kaen.
The common stuff went into devices.c/h, and the board-specific stuff
is in board-seaboard-sensors.c and board-kaen-sensors.c, respectively.

Change-Id: I7de5c29e5cb6e289d24108e416083b08937c9db7

Signed-off-by: Andrew Chew <achew@nvidia.com>;

BUG=none
TEST=Builds cleanly.  Tested to work with Tegra's V4L2 stuff on Seaboard and Kaen

[Olof Johansson, 2011-03-21 22:22:05]

Hmm. I would prefer to see a proper gpio driver for tca6414 instead of the
hardcoded stuff that is in there now.

Also, please clean up the patches a bit: remove filenames from the top (since
they are wrong), and remove C99 comments.

How much of this could be refactored into a common file that's shared between
the boards instead, especially if tca6414 setup is extracted out?

[Andrew Chew, 2011-03-21 22:31:22]

> How much of this could be refactored into a common file that's shared between
> the boards instead, especially if tca6414 setup is extracted out?

I don't know.  These two mux devices are very specific to the Seaboard camera
module.  If anything, I can see having two "sensors" board files...one for
seaboard, and one for "generic".

If forced, I think we can put this stuff into a common file, but I'm not
convinced it will help clarity or maintenance.

[Andrew Chew, 2011-03-28 21:05:27]

Updated this CL.  Fixed C99 comments, and other stuff reported by checkpatch (it
is clean now).  Removed filenames from comment header, and fixed copyright. 
Added work-in-progress aebl sensors file.

When the aebl sensor is working, we can look at consolidating the sensors file. 
Right now, I don't know how much the aebl and kaen ones will differ at the end
of the day.

[Olof Johansson, 2011-03-28 22:41:44]

Looks better, a few additional comments below.

http://codereview.chromium.org/6627032/diff/4001/arch/arm/mach-tegra/board-ae...
File arch/arm/mach-tegra/board-aebl-sensors.c (right):

http://codereview.chromium.org/6627032/diff/4001/arch/arm/mach-tegra/board-ae...
arch/arm/mach-tegra/board-aebl-sensors.c:84: /*	regulator_disable(regulator);*/
Shouldn't this just be removed?

http://codereview.chromium.org/6627032/diff/4001/arch/arm/mach-tegra/board-ka...
File arch/arm/mach-tegra/board-kaen-sensors.c (right):

http://codereview.chromium.org/6627032/diff/4001/arch/arm/mach-tegra/board-ka...
arch/arm/mach-tegra/board-kaen-sensors.c:84: /*	regulator_disable(regulator); */
Same here, please remove.

http://codereview.chromium.org/6627032/diff/4001/arch/arm/mach-tegra/board-se...
File arch/arm/mach-tegra/board-seaboard-power.c (right):

http://codereview.chromium.org/6627032/diff/4001/arch/arm/mach-tegra/board-se...
arch/arm/mach-tegra/board-seaboard-power.c:197: ldo6_data.constraints.apply_uV =
1;
Should the changes to this file be a separate patch?

http://codereview.chromium.org/6627032/diff/4001/arch/arm/mach-tegra/board-se...
File arch/arm/mach-tegra/board-seaboard-sensors.c (right):

http://codereview.chromium.org/6627032/diff/4001/arch/arm/mach-tegra/board-se...
arch/arm/mach-tegra/board-seaboard-sensors.c:100: #endif
If you provide empty stubs of these functions (or encapsulate the body in ifdef)
then you don't have to ifdef away the call sites below.

http://codereview.chromium.org/6627032/diff/4001/arch/arm/mach-tegra/board-se...
arch/arm/mach-tegra/board-seaboard-sensors.c:197: transaction. */
/* Comment style
 * should be
 * like this.
 */

http://codereview.chromium.org/6627032/diff/4001/arch/arm/mach-tegra/board-se...
arch/arm/mach-tegra/board-seaboard-sensors.c:203:
/*	gpio_free(TEGRA_CAMERA_GPIO_PMU); */
More commented out code.

http://codereview.chromium.org/6627032/diff/4001/arch/arm/mach-tegra/board-se...
arch/arm/mach-tegra/board-seaboard-sensors.c:286: clk_csus =
clk_get_sys("tegra_camera", "csus");
Maybe print a warning if any of those clock gets fail?

http://codereview.chromium.org/6627032/diff/4001/arch/arm/mach-tegra/board-se...
File arch/arm/mach-tegra/board-seaboard.h (right):

http://codereview.chromium.org/6627032/diff/4001/arch/arm/mach-tegra/board-se...
arch/arm/mach-tegra/board-seaboard.h:56: int aebl_sensors_init(void);
Since the -sensors file only builds when the board is enabled, I think you need
to provide stubs here if it's not enabled, or the build will fail.

[Andrew Chew, 2011-03-28 23:29:54]

Holy smokes, those CLs did go through after all.  Sorry for the dozen patchsets
:)

Anyway, addressed all of your comments.  I'll push the change to
board-seaboard-power.c in a separate issue.

[Olof Johansson, 2011-03-28 23:52:56]

http://codereview.chromium.org/6627032/diff/8003/arch/arm/mach-tegra/board-se...
File arch/arm/mach-tegra/board-seaboard.h (right):

http://codereview.chromium.org/6627032/diff/8003/arch/arm/mach-tegra/board-se...
arch/arm/mach-tegra/board-seaboard.h:59: 
This (and the one below) needs to be static inline

[Andrew Chew, 2011-03-28 23:56:25]

Done.

[Olof Johansson, 2011-03-29 01:36:32]

Thanks, applied. Will push tonight.

[Olof Johansson, 2011-03-29 01:37:25]

(touched up subject to be: CHROMIUM: ARM: tegra: seaboard: board file changes
for camera)