Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 662683006: Don't quote the URL in intents sent by adb_run_*_shell. (Closed)

Created:
6 years, 2 months ago by watk
Modified:
6 years, 2 months ago
Reviewers:
*Ted C
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, yfriedman+watch_chromium.org, darin (slow to review), ben+mojo_chromium.org, klundberg+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Don't quote the URL in intents sent by adb_run_*_shell. In Android SDK 21, adb shell started escaping quotes in its arguments. This change removes the literal quotes around the URLs in intents sent by The adb_run_*_shell scripts. BUG=426544 Committed: https://crrev.com/26524ccb345cdcc40d75d45b1db91a0449cd3b62 Cr-Commit-Position: refs/heads/master@{#300975}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -17 lines) Patch
M build/android/adb_run_android_webview_shell View 1 chunk +2 lines, -5 lines 0 comments Download
M build/android/adb_run_chrome_shell View 1 chunk +2 lines, -4 lines 0 comments Download
M build/android/adb_run_content_shell View 1 chunk +2 lines, -4 lines 0 comments Download
M build/android/adb_run_mojo_shell View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
watk
PTAL
6 years, 2 months ago (2014-10-23 21:09:39 UTC) #3
Ted C
lgtm - TIL what bash default value was...thank you :-)
6 years, 2 months ago (2014-10-23 21:17:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/662683006/1
6 years, 2 months ago (2014-10-23 21:24:57 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-23 23:19:33 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-23 23:19:50 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/26524ccb345cdcc40d75d45b1db91a0449cd3b62
Cr-Commit-Position: refs/heads/master@{#300975}

Powered by Google App Engine
This is Rietveld 408576698