build/android/adb_run_chrome_shell - Issue 662683006: Don't quote the URL in intents sent by adb_run_*_shell.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/adb_run_chrome_shell

Issue 662683006: Don't quote the URL in intents sent by adb_run_*_shell. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/adb_run_chrome_shell

diff --git a/build/android/adb_run_chrome_shell b/build/android/adb_run_chrome_shell

index 46558b3bbcfca1b1ce813b578ae7448a92b2c712..79c4c32b5c3408387ec211d304d88538e2b3b06c 100755

--- a/build/android/adb_run_chrome_shell

+++ b/build/android/adb_run_chrome_shell

@@ -4,11 +4,9 @@

# Use of this source code is governed by a BSD-style license that can be

# found in the LICENSE file.

-if [ $# -gt 0 ] ; then

- INTENT_ARGS="-d \"$1\"" # e.g. a URL

-fi

+optional_url=$1

adb shell am start \

-a android.intent.action.VIEW \

-n org.chromium.chrome.shell/.ChromeShellActivity \

- $INTENT_ARGS

+ ${optional_url:+-d "$optional_url"}

« no previous file with comments | « build/android/adb_run_android_webview_shell ('k') | build/android/adb_run_content_shell » ('j') | no next file with comments »