Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3246)

Unified Diff: dart/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/sdk/SdkLibrariesReader.java

Issue 66253002: Version 0.8.10.9 (Closed) Base URL: http://dart.googlecode.com/svn/trunk/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/sdk/SdkLibrariesReader.java
===================================================================
--- dart/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/sdk/SdkLibrariesReader.java (revision 30098)
+++ dart/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/sdk/SdkLibrariesReader.java (working copy)
@@ -24,6 +24,7 @@
import com.google.dart.engine.ast.visitor.RecursiveASTVisitor;
import com.google.dart.engine.error.AnalysisError;
import com.google.dart.engine.error.AnalysisErrorListener;
+import com.google.dart.engine.error.ErrorType;
import com.google.dart.engine.parser.Parser;
import com.google.dart.engine.scanner.CharSequenceReader;
import com.google.dart.engine.scanner.Scanner;
@@ -162,7 +163,10 @@
AnalysisErrorListener errorListener = new AnalysisErrorListener() {
@Override
public void onError(AnalysisError error) {
- foundError[0] = true;
+ // TODO (danrubel): Remove this TODO check once TODO scraping is moved out of parser
+ if (error != null && error.getErrorCode().getType() != ErrorType.TODO) {
+ foundError[0] = true;
+ }
}
};
Source source = new FileBasedSource(null, librariesFile, UriKind.FILE_URI);

Powered by Google App Engine
This is Rietveld 408576698