Version 0.8.10.9

dart/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/sdk/SdkLibrariesReader.java

 /*
  * Copyright (c) 2012, the Dart project authors.
  * 
  * Licensed under the Eclipse Public License v1.0 (the "License"); you may not use this file except
  * in compliance with the License. You may obtain a copy of the License at
  * 
  * http://www.eclipse.org/legal/epl-v10.html
  * 
  * Unless required by applicable law or agreed to in writing, software distributed under the License
  * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
  * or implied. See the License for the specific language governing permissions and limitations under
  * the License.
  */
 package com.google.dart.engine.internal.sdk;
 
 import com.google.dart.engine.ast.BooleanLiteral;
 import com.google.dart.engine.ast.CompilationUnit;
 import com.google.dart.engine.ast.Expression;
 import com.google.dart.engine.ast.InstanceCreationExpression;
 import com.google.dart.engine.ast.MapLiteralEntry;
 import com.google.dart.engine.ast.NamedExpression;
 import com.google.dart.engine.ast.SimpleIdentifier;
 import com.google.dart.engine.ast.SimpleStringLiteral;
 import com.google.dart.engine.ast.visitor.RecursiveASTVisitor;
 import com.google.dart.engine.error.AnalysisError;
 import com.google.dart.engine.error.AnalysisErrorListener;
+import com.google.dart.engine.error.ErrorType;
 import com.google.dart.engine.parser.Parser;
 import com.google.dart.engine.scanner.CharSequenceReader;
 import com.google.dart.engine.scanner.Scanner;
 import com.google.dart.engine.source.FileBasedSource;
 import com.google.dart.engine.source.Source;
 import com.google.dart.engine.source.UriKind;
 
 import java.io.File;
 import java.util.List;
 
@@ skipping 118 matching lines @@
   /**
    * Return the library map read from the given source.
    * 
    * @return the library map read from the given source
    */
   public LibraryMap readFrom(File librariesFile, String libraryFileContents) {
     final boolean[] foundError = {false};
     AnalysisErrorListener errorListener = new AnalysisErrorListener() {
       @Override
       public void onError(AnalysisError error) {
-        foundError[0] = true;
+        // TODO (danrubel): Remove this TODO check once TODO scraping is moved out of parser
+        if (error != null && error.getErrorCode().getType() != ErrorType.TODO) {
+          foundError[0] = true;
+        }
       }
     };
     Source source = new FileBasedSource(null, librariesFile, UriKind.FILE_URI);
     Scanner scanner = new Scanner(
         source,
         new CharSequenceReader(libraryFileContents),
         errorListener);
     Parser parser = new Parser(source, errorListener);
     CompilationUnit unit = parser.parseCompilationUnit(scanner.tokenize());
     LibraryBuilder libraryBuilder = new LibraryBuilder();
     // If any syntactic errors were found then don't try to visit the AST structure.
     if (!foundError[0]) {
       unit.accept(libraryBuilder);
     }
     return libraryBuilder.getLibrariesMap();
   }
 }