Issue 662523003: Add a very minimal CSSAgent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 662523003: Add a very minimal CSSAgent (Closed)

Created:
6 years, 1 month ago by eseidel

Modified:
6 years, 1 month ago

Reviewers:
esprehn, abarth-chromium

CC:
esprehn, abarth-chromium, mojo-reviews_chromium.org, ojan

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Add a very minimal CSSAgent Also fixed the exception caused by IndexedDB being missing. It was there, just not used by inspector.sky. R=esprehn@chromium.org, abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/8e8f143027655042c0dde93b4a234db1aacef06f

Patch Set 1 #

Total comments: 1

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+105 lines, -18 lines)			Patch
A	sky/framework/inspector/css-agent.sky	View	1 chunk	+51 lines, -0 lines	0 comments	Download
A	sky/framework/inspector/debug.sky	View	1 chunk	+16 lines, -0 lines	0 comments	Download
M	sky/framework/inspector/dom-agent.sky	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	sky/framework/inspector/inspector.sky	View	3 chunks	+14 lines, -3 lines	0 comments	Download
M	sky/framework/inspector/runtime-agent.sky	View	5 chunks	+3 lines, -16 lines	0 comments	Download
A	sky/tests/inspector/css-computed-style.sky	View	1 chunk	+18 lines, -0 lines	1 comment	Download
A +	sky/tests/inspector/css-computed-style-expected.txt	View	0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

esprehn

lgtm https://codereview.chromium.org/662523003/diff/1/sky/tests/inspector/css-computed-style.sky File sky/tests/inspector/css-computed-style.sky (right): https://codereview.chromium.org/662523003/diff/1/sky/tests/inspector/css-computed-style.sky#newcode15 sky/tests/inspector/css-computed-style.sky:15: assert.isTrue(response["computedStyle"].length > 0); assert.isNotEmpty ?

6 years, 1 month ago (2014-10-29 21:08:41 UTC) #3

eseidel

6 years, 1 month ago (2014-10-29 21:14:10 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
8e8f143027655042c0dde93b4a234db1aacef06f (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages