Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: sky/framework/inspector/inspector.sky

Issue 662523003: Add a very minimal CSSAgent (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/framework/inspector/inspector.sky
diff --git a/sky/framework/inspector/inspector.sky b/sky/framework/inspector/inspector.sky
index a2dd5ffab35e14f3162c5bc03a5b275e9fe34417..bd42cb36fd934e45a2613b829eb6ce24fcb9fae9 100644
--- a/sky/framework/inspector/inspector.sky
+++ b/sky/framework/inspector/inspector.sky
@@ -8,17 +8,21 @@
<link rel="import" href="worker-agent.sky" as="WorkerAgent" />
<link rel="import" href="runtime-agent.sky" as="RuntimeAgent" />
<link rel="import" href="indexeddb-agent.sky" as="IndexedDBAgent" />
+<link rel="import" href="css-agent.sky" as="CSSAgent" />
<script>
function InspectorBackend(frontend) {
this.frontend = frontend;
+ var domAgent = new DOMAgent(this);
this.agents = {
Console: new ConsoleAgent(),
- DOM: new DOMAgent(this),
+ DOM: domAgent,
Page: new PageAgent(),
Worker: new WorkerAgent(),
Runtime: new RuntimeAgent(this),
+ CSS: new CSSAgent(domAgent),
IndexedDB: new IndexedDBAgent(),
};
+ this.missingNames_ = {};
}
InspectorBackend.prototype = Object.create(
@@ -30,6 +34,13 @@ InspectorBackend.prototype.onConnect = function() {
InspectorBackend.prototype.onDisconnect = function() {
};
+InspectorBackend.prototype.logMissing_ = function(name) {
+ if (name in this.missingNames_)
+ return;
+ this.missingNames_[name] = true;
+ console.log("InspectorBackend missing " + name);
+}
+
InspectorBackend.prototype.dispatch_ = function(descriptor, params) {
var parsed = descriptor.split('.');
@@ -37,14 +48,14 @@ InspectorBackend.prototype.dispatch_ = function(descriptor, params) {
var methodName = parsed[1];
if (!(agentName in this.agents)) {
- console.log("InspectorBackend missing " + agentName);
+ this.logMissing_(agentName);
return {};
}
var agent = this.agents[agentName];
if (!(methodName in agent)) {
- console.log("InspectorBackend missing " + agentName + "." + methodName);
+ this.logMissing_(agentName + "." + methodName);
return {};
}

Powered by Google App Engine
This is Rietveld 408576698