Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 6624071: [Isolates] Use _exit() instead of exit() in shell to avoid shutdown (Closed)

Created:
9 years, 9 months ago by Vitaly Repeshko
Modified:
9 years, 7 months ago
Reviewers:
Dmitry Titov
CC:
v8-dev
Visibility:
Public.

Description

[Isolates] Use _exit() instead of exit() in shell to avoid shutdown races between static descructors and isolate threads. Our tests that throw exceptions used to call exit() in the thread that threw the exception. This invoked static descructors while the other threads were still running and we had all kinds of bad effects. Committed: http://code.google.com/p/v8/source/detail?r=7090

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -5 lines) Patch
M samples/shell.cc View 5 chunks +14 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Vitaly Repeshko
9 years, 9 months ago (2011-03-07 22:50:14 UTC) #1
Dmitry Titov
9 years, 9 months ago (2011-03-07 23:32:03 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698