Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 662393007: DevTools: Make compile_frontend.py check code from all applications (Closed)

Created:
6 years, 2 months ago by apavlov
Modified:
6 years, 2 months ago
Reviewers:
dgozman, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Make compile_frontend.py check code from all applications R=dgozman BUG=425911 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184188

Patch Set 1 : #

Patch Set 2 : Restructure DescriptorLoader to be able to merge multiple applications #

Total comments: 2

Patch Set 3 : Address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -23 lines) Patch
M Source/devtools/front_end/Runtime.js View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/scripts/compile_frontend.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M Source/devtools/scripts/concatenate_application_code.py View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/scripts/modular_build.py View 1 2 3 chunks +32 lines, -20 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
apavlov
6 years, 2 months ago (2014-10-22 09:00:15 UTC) #1
dgozman
Everything except Runtime.js looks good. https://codereview.chromium.org/662393007/diff/40001/Source/devtools/scripts/modular_build.py File Source/devtools/scripts/modular_build.py (right): https://codereview.chromium.org/662393007/diff/40001/Source/devtools/scripts/modular_build.py#newcode154 Source/devtools/scripts/modular_build.py:154: module_descriptors[module_name] = self._read_module_descriptor(module_name, application_descriptor_filename) ...
6 years, 2 months ago (2014-10-22 12:48:24 UTC) #3
apavlov
+pfeldman
6 years, 2 months ago (2014-10-22 12:48:42 UTC) #5
dgozman
lgtm
6 years, 2 months ago (2014-10-22 12:51:03 UTC) #6
apavlov
https://codereview.chromium.org/662393007/diff/40001/Source/devtools/scripts/modular_build.py File Source/devtools/scripts/modular_build.py (right): https://codereview.chromium.org/662393007/diff/40001/Source/devtools/scripts/modular_build.py#newcode154 Source/devtools/scripts/modular_build.py:154: module_descriptors[module_name] = self._read_module_descriptor(module_name, application_descriptor_filename) On 2014/10/22 12:48:24, dgozman wrote: ...
6 years, 2 months ago (2014-10-22 13:14:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/662393007/60001
6 years, 2 months ago (2014-10-22 13:16:15 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 15:00:29 UTC) #10
Message was sent while issue was closed. 
Committed patchset #3 (id:60001) as 184188

Powered by Google App Engine
This is Rietveld 408576698