Source/devtools/scripts/concatenate_application_code.py - Issue 662393007: DevTools: Make compile_frontend.py check code from all applications

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/scripts/concatenate_application_code.py

Issue 662393007: DevTools: Make compile_frontend.py check code from all applications (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Address comment Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/devtools/scripts/concatenate_application_code.py

diff --git a/Source/devtools/scripts/concatenate_application_code.py b/Source/devtools/scripts/concatenate_application_code.py

index e239983340350dff56a3d7b67780664115c0ac44..efcdbc9899f64b30a83d7bad87c469f15fbfc374 100755

--- a/Source/devtools/scripts/concatenate_application_code.py

+++ b/Source/devtools/scripts/concatenate_application_code.py

@@ -194,7 +194,7 @@ class ReleaseBuilder(AppBuilder):

self._concatenate_autostart_modules(output)

output.write('/* Application descriptor %s */\n' % self.app_file('json'))

output.write('applicationDescriptor = ')

- output.write(self.descriptors.application_json)

+ output.write(self.descriptors.application_json())

output.write(';\n/* Core CSS */\n')

self._write_module_css_styles(self.core_css_names(), output)

output.write('\n/* Application loader */\n')