Issue 662393003: Revert 183623 "Fix fullscreen elements in pinch viewport mode."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 662393003: Revert 183623 "Fix fullscreen elements in pinch viewport mode." (Closed)

Created:
6 years, 2 months ago by kareng

Modified:
6 years, 2 months ago

Reviewers:
aelias_OOO_until_Jul13

CC:
blink-reviews, kenneth.christiansen, blink-reviews-rendering, zoltan1, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, mkwst+moarreviews_chromium.org, blink-layers+watch_chromium.org, jchaffraix+rendering, rune+blink

Base URL:
svn://svn.chromium.org/blink/branches/chromium/2194/

Project:
blink

Visibility:
Public.

More Reviews

Description

Revert 183623 "Fix fullscreen elements in pinch viewport mode." > Fix fullscreen elements in pinch viewport mode. > > In pinch viewport mode, the size of the FrameView is always the content > width of the document (not the true viewport size), so this patch plumbs > the viewport size to fullscreen elements separately. Secondly, in this > mode there is an "inner viewport" that scrolls separately and whose > scrollability additionally needs to be disabled. Do so by using > setUserScrollable() (which is a mechanism that only works in this mode). > > BUG=411072 > > Review URL: https://codereview.chromium.org/636363003 TBR=aelias@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183996

Patch Set 1 #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -101 lines)			Patch
M	Source/core/frame/FrameView.cpp	View	2 chunks	+0 lines, -6 lines	0 comments	Download
M	Source/core/frame/PinchViewport.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	Source/core/page/scrolling/ScrollingCoordinator.cpp	View	1 chunk	+7 lines, -16 lines	0 comments	Download
M	Source/core/rendering/RenderFullScreen.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/rendering/RenderFullScreen.cpp	View	4 chunks	+5 lines, -17 lines	0 comments	Download
M	Source/web/WebViewImpl.cpp	View	3 chunks	+0 lines, -5 lines	0 comments	Download
M	Source/web/tests/WebFrameTest.cpp	View	8 chunks	+10 lines, -51 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as r183996.

Expand Messages | Collapse Messages