Fix fullscreen elements in pinch viewport mode.

Fix fullscreen elements in pinch viewport mode.

In pinch viewport mode, the size of the FrameView is always the content
width of the document (not the true viewport size), so this patch plumbs
the viewport size to fullscreen elements separately.  Secondly, in this
mode there is an "inner viewport" that scrolls separately and whose
scrollability additionally needs to be disabled.  Do so by using
setUserScrollable() (which is a mechanism that only works in this mode).

BUG=411072
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183623

[aelias_OOO_until_Jul13, 2014-10-09 00:26:56]

aelias@chromium.org changed reviewers:
+ bokan@chromium.org, falken@chromium.org, rbyers@chromium.org

[aelias_OOO_until_Jul13, 2014-10-09 00:27:17]

PTAL.  bokan@ and falken@ for initial review, rbyers@ for Source/core OWNERS.

[falken, 2014-10-09 02:17:26]

lgtm

[bokan, 2014-10-09 02:19:18]

lgtm

https://codereview.chromium.org/636363003/diff/1/Source/core/frame/PinchViewp...
File Source/core/frame/PinchViewport.h (right):

https://codereview.chromium.org/636363003/diff/1/Source/core/frame/PinchViewp...
Source/core/frame/PinchViewport.h:78: GraphicsLayer* innerViewportScrollLayer()
It's unambiguous and consistent with the above if we just call this scrollLayer

https://codereview.chromium.org/636363003/diff/1/Source/web/tests/WebFrameTes...
File Source/web/tests/WebFrameTest.cpp (right):

https://codereview.chromium.org/636363003/diff/1/Source/web/tests/WebFrameTes...
Source/web/tests/WebFrameTest.cpp:6149: WebViewImpl* webViewImpl =
webViewHelper.initializeAndLoad(m_baseURL + "fullscreen_div.html", true, 0,
&client, configurePinchVirtualViewport);
Do you think it's worth keeping a copy of these tests that run in the old mode
until we're ready to permanently rip out the old path?

[aelias_OOO_until_Jul13, 2014-10-09 03:56:24]

https://codereview.chromium.org/636363003/diff/1/Source/web/tests/WebFrameTes...
File Source/web/tests/WebFrameTest.cpp (right):

https://codereview.chromium.org/636363003/diff/1/Source/web/tests/WebFrameTes...
Source/web/tests/WebFrameTest.cpp:6149: WebViewImpl* webViewImpl =
webViewHelper.initializeAndLoad(m_baseURL + "fullscreen_div.html", true, 0,
&client, configurePinchVirtualViewport);
On 2014/10/09 02:19:18, bokan wrote:
> Do you think it's worth keeping a copy of these tests that run in the old mode
> until we're ready to permanently rip out the old path?

I don't think we should, as we're going to turn on the new path soon and the
permanently ripping out shouldn't be long after that.

[Rick Byers, 2014-10-09 14:28:52]

https://codereview.chromium.org/636363003/diff/1/Source/core/page/scrolling/S...
File Source/core/page/scrolling/ScrollingCoordinator.cpp (right):

https://codereview.chromium.org/636363003/diff/1/Source/core/page/scrolling/S...
Source/core/page/scrolling/ScrollingCoordinator.cpp:168:
toWebLayer(m_page->frameHost().pinchViewport().innerViewportScrollLayer())->setUserScrollable(false,
false);
ScrollView::setScrollbarModes can override this.  Are you sure it can never be
called when there is a fullscreen element?  Perhaps it would be better to have a
single code path that calls setUserScrollable that considers both the scrollbar
state and fullscreen mode, then call that here and from
ScrollView::setScrollbarModes?

[aelias_OOO_until_Jul13, 2014-10-10 00:58:51]

https://codereview.chromium.org/636363003/diff/1/Source/core/frame/PinchViewp...
File Source/core/frame/PinchViewport.h (right):

https://codereview.chromium.org/636363003/diff/1/Source/core/frame/PinchViewp...
Source/core/frame/PinchViewport.h:78: GraphicsLayer* innerViewportScrollLayer()
On 2014/10/09 at 02:19:18, bokan wrote:
> It's unambiguous and consistent with the above if we just call this
scrollLayer

Done.

https://codereview.chromium.org/636363003/diff/1/Source/core/page/scrolling/S...
File Source/core/page/scrolling/ScrollingCoordinator.cpp (right):

https://codereview.chromium.org/636363003/diff/1/Source/core/page/scrolling/S...
Source/core/page/scrolling/ScrollingCoordinator.cpp:168:
toWebLayer(m_page->frameHost().pinchViewport().innerViewportScrollLayer())->setUserScrollable(false,
false);
On 2014/10/09 at 14:28:52, Rick Byers wrote:
> ScrollView::setScrollbarModes can override this.  Are you sure it can never be
called when there is a fullscreen element?  Perhaps it would be better to have a
single code path that calls setUserScrollable that considers both the scrollbar
state and fullscreen mode, then call that here and from
ScrollView::setScrollbarModes?

Good point.  I overrode the userInputScrollable getter in FrameView to check
whether we're fullscreen, since all the callers do an update based on that.

[Rick Byers, 2014-10-10 16:07:28]

LGTM

[aelias_OOO_until_Jul13, 2014-10-10 20:08:12]

The CQ bit was checked by aelias@chromium.org

[commit-bot: I haz the power, 2014-10-10 20:09:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/636363003/70011

[commit-bot: I haz the power, 2014-10-10 21:45:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-10 21:45:08]

Failed to apply patch for Source/core/frame/FrameView.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/frame/FrameView.h
  Hunk #1 FAILED at 84.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/core/frame/FrameView.h.rej

Patch:       Source/core/frame/FrameView.h
Index: Source/core/frame/FrameView.h
diff --git a/Source/core/frame/FrameView.h b/Source/core/frame/FrameView.h
index
f3488f75d79d43e26f9854532e42ac37ef0739d1..d3ee7591baf81cea7b6585c9c1c57ee35a541154
100644
--- a/Source/core/frame/FrameView.h
+++ b/Source/core/frame/FrameView.h
@@ -84,6 +84,7 @@ public:
     RenderView* renderView() const;
 
     virtual void setCanHaveScrollbars(bool) override;
+    virtual bool userInputScrollable(ScrollbarOrientation) const override;
 
     virtual PassRefPtr<Scrollbar> createScrollbar(ScrollbarOrientation)
override;

[aelias_OOO_until_Jul13, 2014-10-10 22:29:06]

The CQ bit was checked by aelias@chromium.org

[commit-bot: I haz the power, 2014-10-10 22:30:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/636363003/380001

[aelias_OOO_until_Jul13, 2014-10-10 22:34:24]

The CQ bit was unchecked by aelias@chromium.org

[aelias_OOO_until_Jul13, 2014-10-10 22:54:22]

The CQ bit was checked by aelias@chromium.org

[commit-bot: I haz the power, 2014-10-10 22:54:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/636363003/210002

[commit-bot: I haz the power, 2014-10-11 01:12:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-11 01:12:53]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/31278)

[pdr., 2014-10-11 03:06:28]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2014-10-11 03:07:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/636363003/210002

[commit-bot: I haz the power, 2014-10-11 03:07:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-11 03:07:32]

Failed to apply patch for Source/web/WebViewImpl.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/web/WebViewImpl.cpp
  Hunk #2 FAILED at 81.
  1 out of 3 hunks FAILED -- saving rejects to file
Source/web/WebViewImpl.cpp.rej

Patch:       Source/web/WebViewImpl.cpp
Index: Source/web/WebViewImpl.cpp
diff --git a/Source/web/WebViewImpl.cpp b/Source/web/WebViewImpl.cpp
index
38a0553d0af224ed7fd473dcc023b28adf606ec6..d0d728e948854cdccfeec7e9e31fae0e4bebc4ee
100644
--- a/Source/web/WebViewImpl.cpp
+++ b/Source/web/WebViewImpl.cpp
@@ -38,6 +38,7 @@
 #include "core/clipboard/DataObject.h"
 #include "core/dom/Document.h"
 #include "core/dom/DocumentMarkerController.h"
+#include "core/dom/Fullscreen.h"
 #include "core/dom/NodeRenderingTraversal.h"
 #include "core/dom/Text.h"
 #include "core/editing/Editor.h"
@@ -80,6 +81,7 @@
 #include "core/page/PointerLockController.h"
 #include "core/page/ScopedPageLoadDeferrer.h"
 #include "core/page/TouchDisambiguation.h"
+#include "core/rendering/RenderFullScreen.h"
 #include "core/rendering/RenderView.h"
 #include "core/rendering/RenderWidget.h"
 #include "core/rendering/TextAutosizer.h"
@@ -1757,6 +1759,9 @@ void WebViewImpl::resize(const WebSize& newSize)
         performResize();
     }
 
+    if (m_fullscreenController->isFullscreen())
+       
Fullscreen::from(*view->frame().document()).fullScreenRenderer()->updateStyle();
+
     if (settings()->viewportEnabled()) {
         // Relayout immediately to recalculate the minimum scale limit.
         if (view->needsLayout())

[aelias_OOO_until_Jul13, 2014-10-13 19:12:30]

The CQ bit was checked by aelias@chromium.org

[commit-bot: I haz the power, 2014-10-13 19:13:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/636363003/690001

[commit-bot: I haz the power, 2014-10-13 19:51:23]

Committed patchset #7 (id:690001) as 183623