chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc - Issue 662073002: Fix crash when user closes window prior to the "Confirm Install" prompt showing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc

Issue 662073002: Fix crash when user closes window prior to the "Confirm Install" prompt showing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git/+/install_prompt_navigator

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/native_window_deletion_observer.h ('K') | « chrome/browser/ui/views/extensions/extension_install_dialog_view.cc ('k') | chrome/chrome_browser_extensions.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc

diff --git a/chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc b/chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc

index cecada130e307bf506651105d1124619a6704c3b..aeeb9b13f041cb4423584c6413e195ed59a7c9c2 100644

--- a/chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc

+++ b/chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc

@@ -161,16 +161,16 @@ ScrollbarTest::ScrollbarTest()

}

bool ScrollbarTest::IsScrollbarVisible() {

- ExtensionInstallPrompt::ShowParams show_params(web_contents());

ExtensionInstallDialogView* dialog = new ExtensionInstallDialogView(

- show_params.profile,

- show_params.parent_web_contents,

+ profile(),

+ web_contents(),

delegate(),

prompt());

// Create the modal view around the install dialog view.

views::Widget* modal =

- CreateBrowserModalDialogViews(dialog, show_params.parent_window);

+ CreateBrowserModalDialogViews(dialog,

+ web_contents()->GetTopLevelNativeWindow());

modal->Show();

content::RunAllBlockingPoolTasksUntilIdle();