chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller.h - Issue 662073002: Fix crash when user closes window prior to the "Confirm Install" prompt showing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller.h

Issue 662073002: Fix crash when user closes window prior to the "Confirm Install" prompt showing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git/+/install_prompt_navigator

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/aura/native_window_deletion_observer_aura.cc ('K') | « chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller_browsertest.mm ('k') | chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller.mm » ('j') | chrome/browser/ui/native_window_deletion_observer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller.h

diff --git a/chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller.h b/chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller.h

index 92903792bad21d893d1d2d9e0f2448745aaf4f83..ca787c0a663e389a7e1c9a652092fec6aad67b31 100644

--- a/chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller.h

+++ b/chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller.h

@@ -11,6 +11,7 @@

#include "base/mac/scoped_nsobject.h"

#include "chrome/browser/extensions/extension_install_prompt.h"

+class ExtensionInstallPromptShowParams;

@class ExtensionInstallViewController;

@class WindowedInstallController;

@@ -22,7 +23,7 @@ class WindowedInstallDialogController

// Initializes the ExtensionInstallViewController and shows the window. This

// object will delete itself when the window is closed.

WindowedInstallDialogController(

- const ExtensionInstallPrompt::ShowParams& show_params,

+ ExtensionInstallPromptShowParams* show_params,

ExtensionInstallPrompt::Delegate* delegate,

scoped_refptr<ExtensionInstallPrompt::Prompt> prompt);

~WindowedInstallDialogController() override;