chrome/browser/ui/native_window_deletion_observer.h - Issue 662073002: Fix crash when user closes window prior to the "Confirm Install" prompt showing

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/native_window_deletion_observer.h

Issue 662073002: Fix crash when user closes window prior to the "Confirm Install" prompt showing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git/+/install_prompt_navigator

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/ui/aura/native_window_deletion_observer_aura.cc ('K') | « chrome/browser/ui/cocoa/native_window_deletion_observer_cocoa.mm ('k') | chrome/browser/ui/views/extensions/extension_install_dialog_view.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_UI_NATIVE_WINDOW_DELETION_OBSERVER_H_

	6 #define CHROME_BROWSER_UI_NATIVE_WINDOW_DELETION_OBSERVER_H_

	7

	8 #include "base/memory/scoped_ptr.h"

	9 #include "ui/gfx/native_widget_types.h"

	10

	11 // An observer which can be probed for the life of a gfx::NativeWindow.

	12 class NativeWindowDeletionObserver {
	sky 2014/10/24 20:22:56 I would be inclined to name this NativeWindowTrack I would be inclined to name this NativeWindowTracker (similar to ui/aura/window_tracker). But I don't feel strongly. If you prefer this name, go with it.
	13 public:

	14 static scoped_ptr<NativeWindowDeletionObserver> Create(
	sky 2014/10/24 20:22:56 style guide says constructor/destructor before oth style guide says constructor/destructor before other functions (including static).
	15 gfx::NativeWindow window);

	16

	17 virtual ~NativeWindowDeletionObserver() {}

	18

	19 // Returns true if the native window passed to Create() is still alive.

	20 virtual bool IsNativeWindowAlive() const = 0;

	21 };

	22

	23 #endif // CHROME_BROWSER_UI_NATIVE_WINDOW_DELETION_OBSERVER_H_

OLD	NEW