Potential bug on drawing video on SkCanvas

media/filters/skcanvas_video_renderer.h

Index: media/filters/skcanvas_video_renderer.h
diff --git a/media/filters/skcanvas_video_renderer.h b/media/filters/skcanvas_video_renderer.h
index 146e7cd16cec099ffc12b62019a4b1c466f59b63..2a157b3ed8891bdf4ff4ac4b2af892be11ad14c1 100644
--- a/media/filters/skcanvas_video_renderer.h
+++ b/media/filters/skcanvas_video_renderer.h
@@ -42,13 +42,19 @@ class MEDIA_EXPORT SkCanvasVideoRenderer {
   void Copy(const scoped_refptr<VideoFrame>&, SkCanvas* canvas);
 
  private:
-  VideoImageGenerator* generator_;
+  void CleanUpTemporaryBuffers();
 
   // An RGB bitmap and corresponding timestamp of the previously converted

[scherkus (not reviewing), 2014/10/22 23:17:36]

I would be more explicit here to say it mention this is the result of software
color space conversion.

   // video frame data.
   SkBitmap last_frame_;
   base::TimeDelta last_frame_timestamp_;
 
+  // It's used by accelerated SkCanvas which is passed by a client.

[scherkus (not reviewing), 2014/10/22 23:17:36]

ditto here to highlight that this is a hardware accelerated copy of the frame
generated by |accelerated_generator_|.

+  // Note: all GrContext in SkCanvas instances are same.
+  SkBitmap accelerated_last_frame_;
+  VideoImageGenerator* accelerated_generator_;
+  base::TimeDelta accelerated_last_frame_timestamp_;
+
   DISALLOW_COPY_AND_ASSIGN(SkCanvasVideoRenderer);
 };