Potential bug on drawing video on SkCanvas

media/filters/skcanvas_video_renderer.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_FILTERS_SKCANVAS_VIDEO_RENDERER_H_
 #define MEDIA_FILTERS_SKCANVAS_VIDEO_RENDERER_H_
 
 #include "base/memory/ref_counted.h"
 #include "base/time/time.h"
 #include "media/base/media_export.h"
@@ skipping 24 matching lines @@
              SkCanvas* canvas,
              const gfx::RectF& dest_rect,
              uint8 alpha,
              SkXfermode::Mode mode,
              VideoRotation video_rotation);
 
   // Copy |video_frame| on |canvas|.
   void Copy(const scoped_refptr<VideoFrame>&, SkCanvas* canvas);
 
  private:
-  VideoImageGenerator* generator_;
+  void CleanUpTemporaryBuffers();
 
   // An RGB bitmap and corresponding timestamp of the previously converted

[scherkus (not reviewing), 2014/10/22 23:17:36]

I would be more explicit here to say it mention this is the result of software
color space conversion.

   // video frame data.
   SkBitmap last_frame_;
   base::TimeDelta last_frame_timestamp_;
 
+  // It's used by accelerated SkCanvas which is passed by a client.

[scherkus (not reviewing), 2014/10/22 23:17:36]

ditto here to highlight that this is a hardware accelerated copy of the frame
generated by |accelerated_generator_|.

+  // Note: all GrContext in SkCanvas instances are same.
+  SkBitmap accelerated_last_frame_;
+  VideoImageGenerator* accelerated_generator_;
+  base::TimeDelta accelerated_last_frame_timestamp_;
+
   DISALLOW_COPY_AND_ASSIGN(SkCanvasVideoRenderer);
 };
 
 }  // namespace media
 
 #endif  // MEDIA_FILTERS_SKCANVAS_VIDEO_RENDERER_H_