Source/platform/credentialmanager/PlatformFederatedCredential.h - Issue 661973002: Credential Manager: JavaScript arguments make more sense in a different order.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/credentialmanager/PlatformFederatedCredential.h

Issue 661973002: Credential Manager: JavaScript arguments make more sense in a different order. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git/+/master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/credentialmanager/LocalCredential.idl ('k') | Source/platform/credentialmanager/PlatformFederatedCredential.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/platform/credentialmanager/PlatformFederatedCredential.h

diff --git a/Source/platform/credentialmanager/PlatformFederatedCredential.h b/Source/platform/credentialmanager/PlatformFederatedCredential.h

index d8bb641206e14d8faf5e390763a175e26472d523..389cad535fca3551c2935b89554a2455e25e12af 100644

--- a/Source/platform/credentialmanager/PlatformFederatedCredential.h

+++ b/Source/platform/credentialmanager/PlatformFederatedCredential.h

@@ -14,7 +14,7 @@ namespace blink {

class PLATFORM_EXPORT PlatformFederatedCredential final : public PlatformCredential {

WTF_MAKE_NONCOPYABLE(PlatformFederatedCredential);

public:

- static PlatformFederatedCredential* create(const String& id, const String& name, const KURL& avatarURL, const KURL& federation);

+ static PlatformFederatedCredential* create(const String& id, const KURL& federation, const String& name, const KURL& avatarURL);

virtual ~PlatformFederatedCredential();

const KURL& federation() const { return m_federation; }

@@ -22,7 +22,7 @@ public:

virtual bool isFederated() override { return true; }

private:

- PlatformFederatedCredential(const String& id, const String& name, const KURL& avatarURL, const KURL& federation);

+ PlatformFederatedCredential(const String& id, const KURL& federation, const String& name, const KURL& avatarURL);

KURL m_federation;

};