Source/platform/credentialmanager/PlatformFederatedCredential.cpp - Issue 661973002: Credential Manager: JavaScript arguments make more sense in a different order.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/credentialmanager/PlatformFederatedCredential.cpp

Issue 661973002: Credential Manager: JavaScript arguments make more sense in a different order. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git/+/master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/platform/credentialmanager/PlatformFederatedCredential.h ('k') | Source/platform/credentialmanager/PlatformLocalCredential.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/platform/credentialmanager/PlatformFederatedCredential.cpp

diff --git a/Source/platform/credentialmanager/PlatformFederatedCredential.cpp b/Source/platform/credentialmanager/PlatformFederatedCredential.cpp

index 4d96b922673058a4245b27c3daad705a7ec533fe..c606cfef56a10fbf1f2becb9024b11943d05976e 100644

--- a/Source/platform/credentialmanager/PlatformFederatedCredential.cpp

+++ b/Source/platform/credentialmanager/PlatformFederatedCredential.cpp

@@ -7,12 +7,12 @@

namespace blink {

-PlatformFederatedCredential* PlatformFederatedCredential::create(const String& id, const String& name, const KURL& avatarURL, const KURL& federation)

+PlatformFederatedCredential* PlatformFederatedCredential::create(const String& id, const KURL& federation, const String& name, const KURL& avatarURL)

{

- return new PlatformFederatedCredential(id, name, avatarURL, federation);

+ return new PlatformFederatedCredential(id, federation, name, avatarURL);

}

-PlatformFederatedCredential::PlatformFederatedCredential(const String& id, const String& name, const KURL& avatarURL, const KURL& federation)

+PlatformFederatedCredential::PlatformFederatedCredential(const String& id, const KURL& federation, const String& name, const KURL& avatarURL)

: PlatformCredential(id, name, avatarURL)

, m_federation(federation)

{