Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1011)

Unified Diff: Source/modules/credentialmanager/LocalCredential.h

Issue 661973002: Credential Manager: JavaScript arguments make more sense in a different order. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git/+/master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/credentialmanager/LocalCredential.h
diff --git a/Source/modules/credentialmanager/LocalCredential.h b/Source/modules/credentialmanager/LocalCredential.h
index fab3ca2c6169ef3745e030fac4912b86f62be9ff..9fa7f4f2bd559115f2f9dee24672c38c997520ea 100644
--- a/Source/modules/credentialmanager/LocalCredential.h
+++ b/Source/modules/credentialmanager/LocalCredential.h
@@ -18,15 +18,25 @@ class WebLocalCredential;
class LocalCredential final : public Credential {
DEFINE_WRAPPERTYPEINFO();
public:
+ static LocalCredential* create(const String& id, const String& password, ExceptionState& exceptionState)
+ {
+ return create(id, password, emptyString(), emptyString(), exceptionState);
+ }
+
+ static LocalCredential* create(const String& id, const String& password, const String& name, ExceptionState& exceptionState)
+ {
+ return create(id, password, name, emptyString(), exceptionState);
+ }
+
+ static LocalCredential* create(const String& id, const String& password, const String& name, const String& avatar, ExceptionState&);
static LocalCredential* create(WebLocalCredential*);
- static LocalCredential* create(const String& id, const String& name, const String& avatar, const String& password, ExceptionState&);
// LocalCredential.idl
const String& password() const;
private:
LocalCredential(WebLocalCredential*);
- LocalCredential(const String& id, const String& name, const KURL& avatar, const String& password);
+ LocalCredential(const String& id, const String& password, const String& name, const KURL& avatar);
};
} // namespace blink
« no previous file with comments | « Source/modules/credentialmanager/FederatedCredential.idl ('k') | Source/modules/credentialmanager/LocalCredential.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698