Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1309)

Unified Diff: Source/modules/credentialmanager/LocalCredential.cpp

Issue 661973002: Credential Manager: JavaScript arguments make more sense in a different order. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git/+/master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/credentialmanager/LocalCredential.cpp
diff --git a/Source/modules/credentialmanager/LocalCredential.cpp b/Source/modules/credentialmanager/LocalCredential.cpp
index d69d1f5a20dcbaa8bd37926716da9183adbe00e3..3dc28eb6b34f476a65331dfbab081e34a0b9f639 100644
--- a/Source/modules/credentialmanager/LocalCredential.cpp
+++ b/Source/modules/credentialmanager/LocalCredential.cpp
@@ -17,12 +17,12 @@ LocalCredential* LocalCredential::create(WebLocalCredential* webLocalCredential)
return new LocalCredential(webLocalCredential);
}
-LocalCredential* LocalCredential::create(const String& id, const String& name, const String& avatar, const String& password, ExceptionState& exceptionState)
+LocalCredential* LocalCredential::create(const String& id, const String& password, const String& name, const String& avatar, ExceptionState& exceptionState)
{
KURL avatarURL = parseStringAsURL(avatar, exceptionState);
if (exceptionState.hadException())
return nullptr;
- return new LocalCredential(id, name, avatarURL, password);
+ return new LocalCredential(id, password, name, avatarURL);
}
LocalCredential::LocalCredential(WebLocalCredential* webLocalCredential)
@@ -30,8 +30,8 @@ LocalCredential::LocalCredential(WebLocalCredential* webLocalCredential)
{
}
-LocalCredential::LocalCredential(const String& id, const String& name, const KURL& avatar, const String& password)
- : Credential(PlatformLocalCredential::create(id, name, avatar, password))
+LocalCredential::LocalCredential(const String& id, const String& password, const String& name, const KURL& avatar)
+ : Credential(PlatformLocalCredential::create(id, password, name, avatar))
{
}
« no previous file with comments | « Source/modules/credentialmanager/LocalCredential.h ('k') | Source/modules/credentialmanager/LocalCredential.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698