Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Unified Diff: LayoutTests/http/tests/credentialmanager/federatedcredential-basics.html

Issue 661973002: Credential Manager: JavaScript arguments make more sense in a different order. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git/+/master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/http/tests/credentialmanager/federatedcredential-basics.html
diff --git a/LayoutTests/http/tests/credentialmanager/federatedcredential-basics.html b/LayoutTests/http/tests/credentialmanager/federatedcredential-basics.html
index 63ad3b6d6fcde6f7b1923527eecf6d17ed420abc..b9ff61cb48ee9f47f888cfc2334ee86ceb19cc31 100644
--- a/LayoutTests/http/tests/credentialmanager/federatedcredential-basics.html
+++ b/LayoutTests/http/tests/credentialmanager/federatedcredential-basics.html
@@ -5,7 +5,7 @@
<script src="/serviceworker/resources/interfaces.js"></script>
<script>
test(function() {
- var credential = new FederatedCredential('id', 'name', 'https://example.com/avatar.png', 'https://federation.net/');
+ var credential = new FederatedCredential('id', 'https://federation.net/', 'name', 'https://example.com/avatar.png');
assert_true(credential instanceof Credential);
assert_true(credential instanceof FederatedCredential);
@@ -24,14 +24,32 @@ test(function() {
}, 'Interfaces and attributes of FederatedCredential');
test(function() {
+ var credential = new FederatedCredential('id', 'https://federation.net/', 'name');
+
+ assert_equals(credential.id, 'id');
+ assert_equals(credential.name, 'name');
+ assert_equals(credential.avatarURL, '');
+ assert_equals(credential.federation, 'https://federation.net/');
+}, 'Interfaces and attributes of FederatedCredential');
+
+test(function() {
+ var credential = new FederatedCredential('id', 'https://federation.net/');
+
+ assert_equals(credential.id, 'id');
+ assert_equals(credential.name, '');
+ assert_equals(credential.avatarURL, '');
+ assert_equals(credential.federation, 'https://federation.net/');
+}, 'Interfaces and attributes of FederatedCredential');
+
+test(function() {
assert_throws(new SyntaxError(), function () {
- var credential = new FederatedCredential('id', 'name', '-', 'https://federation.net/');
+ var credential = new FederatedCredential('id', 'https://federation.net/', 'name', '-');
});
}, 'Construct a FederatedCredential with an invalid avatar URL.');
test(function() {
assert_throws(new SyntaxError(), function () {
- var credential = new FederatedCredential('id', 'name', 'https://example.com/avatar.png', '-');
+ var credential = new FederatedCredential('id', '-', 'name', 'https://example.com/avatar.png');
});
}, 'Construct a FederatedCredential with an invalid federation URL.');
</script>

Powered by Google App Engine
This is Rietveld 408576698