LayoutTests/http/tests/credentialmanager/credentialscontainer-notifysignedin-basics.html - Issue 661973002: Credential Manager: JavaScript arguments make more sense in a different order.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/http/tests/credentialmanager/credentialscontainer-notifysignedin-basics.html

Issue 661973002: Credential Manager: JavaScript arguments make more sense in a different order. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git/+/master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/credentialmanager/credentialscontainer-notifyfailedsignin-basics.html ('k') | LayoutTests/http/tests/credentialmanager/federatedcredential-basics.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/http/tests/credentialmanager/credentialscontainer-notifysignedin-basics.html

diff --git a/LayoutTests/http/tests/credentialmanager/credentialscontainer-notifysignedin-basics.html b/LayoutTests/http/tests/credentialmanager/credentialscontainer-notifysignedin-basics.html

index f4b52bcf3093dbd9af91f0e03652da3b58073abc..5abb2741bb043f93e48092ca9f760784dec4ee21 100644

--- a/LayoutTests/http/tests/credentialmanager/credentialscontainer-notifysignedin-basics.html

+++ b/LayoutTests/http/tests/credentialmanager/credentialscontainer-notifysignedin-basics.html

@@ -12,8 +12,8 @@ function stubRejectionChecker(reason) {

assert_unreached("notifySignedIn() should not reject, but did: " + reason.name);

}

-var local = new LocalCredential('id', 'name', 'https://example.com/avatar.png', 'pencil');

-var federated = new FederatedCredential('id', 'name', 'https://example.com/avatar.png', 'https://federation.net');

+var local = new LocalCredential('id', 'pencil', 'name', 'https://example.com/avatar.png');

+var federated = new FederatedCredential('id', 'https://federation.net', 'name', 'https://example.com/avatar.png');

async_test(function () {

navigator.credentials.notifySignedIn().then(