Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Unified Diff: content/test/plugin/plugin_request_read_test.cc

Issue 661833004: Type conversion fixes, content/ edition. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/shell/tools/plugin/PluginObject.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/test/plugin/plugin_request_read_test.cc
diff --git a/content/test/plugin/plugin_request_read_test.cc b/content/test/plugin/plugin_request_read_test.cc
index dfdcd52e948312017d11d439394099384e16dba3..8d04a5e62ef84d660550ac82a7a6867b67d7bafe 100644
--- a/content/test/plugin/plugin_request_read_test.cc
+++ b/content/test/plugin/plugin_request_read_test.cc
@@ -91,11 +91,10 @@ int32 PluginRequestReadTest::Write(NPStream* stream, int32 offset, int32 len,
if (it->length == 0)
requested_ranges_.erase(it);
- // Verify that data, which we got, is right.
+ // Verify the data we got is right. We expect a string like "01234...".
const char* data = static_cast<const char*>(buffer);
for (int32 i = 0; i < len; ++i) {
- int cur_offset = offset + i;
- char expected = '0' + cur_offset;
+ char expected = '0' + static_cast<char>(offset + i);
if (data[i] != expected) {
SetError("Content mismatch between data and source!");
break;
« no previous file with comments | « content/shell/tools/plugin/PluginObject.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698