content/shell/tools/plugin/PluginObject.cpp - Issue 661833004: Type conversion fixes, content/ edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/tools/plugin/PluginObject.cpp

Issue 661833004: Type conversion fixes, content/ edition. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/shell/tools/plugin/PluginObject.cpp

diff --git a/content/shell/tools/plugin/PluginObject.cpp b/content/shell/tools/plugin/PluginObject.cpp

index a28109bb69fcf196d44e653ef78d7e4db18fc3a3..88f1e68ccf07a3bf9580734c851e2a5cc0e23113 100644

--- a/content/shell/tools/plugin/PluginObject.cpp

+++ b/content/shell/tools/plugin/PluginObject.cpp

@@ -1174,10 +1174,10 @@ static bool invalidateRect(PluginObject* obj,

return false;

NPRect rect;

- rect.left = static_cast<int>(NPVARIANT_TO_DOUBLE(args[0]));

- rect.top = static_cast<int>(NPVARIANT_TO_DOUBLE(args[1]));

- rect.right = static_cast<int>(NPVARIANT_TO_DOUBLE(args[2]));

- rect.bottom = static_cast<int>(NPVARIANT_TO_DOUBLE(args[3]));

+ rect.left = static_cast<uint16_t>(NPVARIANT_TO_DOUBLE(args[0]));

+ rect.top = static_cast<uint16_t>(NPVARIANT_TO_DOUBLE(args[1]));

+ rect.right = static_cast<uint16_t>(NPVARIANT_TO_DOUBLE(args[2]));

+ rect.bottom = static_cast<uint16_t>(NPVARIANT_TO_DOUBLE(args[3]));

browser->invalidaterect(obj->npp, &rect);

return true;

« no previous file with comments | « content/common/sandbox_win.cc ('k') | content/test/plugin/plugin_request_read_test.cc » ('j') | no next file with comments »