Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1337)

Issue 661833004: Type conversion fixes, content/ edition. (Closed)

Created:
6 years, 2 months ago by Peter Kasting
Modified:
6 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jam, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Type conversion fixes, content/ edition. This is mostly to fix MSVC warnings about possible value truncation. BUG=81439 TEST=none TBR=cpu Committed: https://crrev.com/dabefe46bc8eb3537d4cee6826d88f8d06e13d52 Cr-Commit-Position: refs/heads/master@{#300159}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -9 lines) Patch
M content/common/sandbox_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/tools/plugin/PluginObject.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M content/test/plugin/plugin_request_read_test.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Peter Kasting
6 years, 2 months ago (2014-10-16 22:51:06 UTC) #2
Avi (use Gerrit)
lgtm
6 years, 2 months ago (2014-10-17 19:40:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/661833004/1
6 years, 2 months ago (2014-10-17 20:35:11 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/18428)
6 years, 2 months ago (2014-10-17 20:43:55 UTC) #7
Peter Kasting
TBRing cpu for trivial change in content/common/sandbox_win.cc.
6 years, 2 months ago (2014-10-17 20:45:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/661833004/1
6 years, 2 months ago (2014-10-17 20:47:21 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-17 20:54:00 UTC) #12
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 20:54:34 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dabefe46bc8eb3537d4cee6826d88f8d06e13d52
Cr-Commit-Position: refs/heads/master@{#300159}

Powered by Google App Engine
This is Rietveld 408576698