Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Unified Diff: Tools/GardeningServer/model/ct-failures.html

Issue 661463004: Include all hung bots alerts in Trooper tree. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Nit (fix line wraps). Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/GardeningServer/model/ct-failures.html
diff --git a/Tools/GardeningServer/model/ct-failures.html b/Tools/GardeningServer/model/ct-failures.html
index 9ddbcbdee1f8df7c37e18e1325900b80d731178b..d68ff81b83cedb37f9010bb606a2d0c1c2183fab 100644
--- a/Tools/GardeningServer/model/ct-failures.html
+++ b/Tools/GardeningServer/model/ct-failures.html
@@ -134,7 +134,7 @@ CTFailures.prototype.update = function() {
}.bind(this));
this.failures = updateUtil.updateLeft(this.failures, newFailures);
- this._processTrooperFailures(trooper_data);
+ this._processTrooperFailures(newFailures, trooper_data);
}.bind(this));
};
@@ -150,13 +150,24 @@ CTFailures.prototype._failureComparator = function(a, b) {
return 0;
};
-CTFailures.prototype._processTrooperFailures = function(data) {
+CTFailures.prototype._processTrooperFailures = function(all_failures,
+ trooper_data) {
var trooper_failures = [];
- Object.keys(data, function(failureType, failuresByTree) {
+ Object.keys(trooper_data, function(failureType, failuresByTree) {
Object.keys(failuresByTree, function(tree, failure) {
if (failure.should_alert) {
trooper_failures.push(new CTFailureGroup('trooper',
- new CTTrooperFailureGroupData(failure.details, failure.url, failure, failureType, tree)));
+ new CTTrooperFailureGroupData(failure.details, failure.url, failure,
+ failureType, tree)));
+ }
+ });
+ });
+
+ //Add any failures that should be listed in the trooper view.
ojan 2014/10/16 21:19:22 This comment doesn't really tell you anything othe
navabi 2014/10/16 23:56:05 Removed.
+ Object.keys(all_failures, function(tree, failuresByTree) {
+ failuresByTree.forEach(function(failure) {
+ if (failure.category == 'builder' || failure.category == 'master') {
+ trooper_failures.push(failure);
}
});
});

Powered by Google App Engine
This is Rietveld 408576698