Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1512)

Unified Diff: content/renderer/push_messaging_dispatcher.h

Issue 661463002: Implement PushManager#hasPermission (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/push_messaging_dispatcher.h
diff --git a/content/renderer/push_messaging_dispatcher.h b/content/renderer/push_messaging_dispatcher.h
index 1d6c87dc7930378e7e69399f57b39da7254f43ab..75e5fa368df4dd0fcd1043d7a6ac51fb12a74836 100644
--- a/content/renderer/push_messaging_dispatcher.h
+++ b/content/renderer/push_messaging_dispatcher.h
@@ -11,6 +11,7 @@
#include "content/public/common/push_messaging_status.h"
#include "content/public/renderer/render_frame_observer.h"
#include "third_party/WebKit/public/platform/WebPushClient.h"
+#include "third_party/WebKit/public/platform/WebPushPermissionStatus.h"
class GURL;
@@ -39,8 +40,10 @@ class PushMessagingDispatcher : public RenderFrameObserver,
// WebPushClient implementation.
virtual void registerPushMessaging(
blink::WebPushRegistrationCallbacks* callbacks,
- blink::WebServiceWorkerProvider* service_worker_provider);
-
+ blink::WebServiceWorkerProvider* service_worker_provider); // override
+ virtual void getPermissionStatus(
+ blink::WebPushPermissionCallback* callback,
+ blink::WebServiceWorkerProvider* service_worker_provider); // override
void DoRegister(blink::WebPushRegistrationCallbacks* callbacks,
mlamouri (slow - plz ping) 2014/10/29 20:13:33 nit: leave an empty line between |getPermissionSta
Miguel Garcia 2014/10/30 12:27:15 Done.
blink::WebServiceWorkerProvider* service_worker_provider,
const Manifest& manifest);
@@ -51,8 +54,14 @@ class PushMessagingDispatcher : public RenderFrameObserver,
void OnRegisterError(int32 callbacks_id, PushRegistrationStatus status);
+ void OnPermissionStatus(int32 callback_id,
+ blink::WebPushPermissionStatus status);
+ void OnPermissionStatusFailure(int32 callback_id);
+
IDMap<blink::WebPushRegistrationCallbacks, IDMapOwnPointer>
registration_callbacks_;
+ IDMap<blink::WebPushPermissionCallback, IDMapOwnPointer>
+ permission_check_callbacks_;
DISALLOW_COPY_AND_ASSIGN(PushMessagingDispatcher);
};

Powered by Google App Engine
This is Rietveld 408576698