Implement PushManager#hasPermission

content/renderer/push_messaging_dispatcher.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_RENDERER_PUSH_MESSAGING_DISPATCHER_H_
 #define CONTENT_RENDERER_PUSH_MESSAGING_DISPATCHER_H_
 
 #include <string>
 
 #include "base/id_map.h"
 #include "content/public/common/push_messaging_status.h"
 #include "content/public/renderer/render_frame_observer.h"
 #include "third_party/WebKit/public/platform/WebPushClient.h"
+#include "third_party/WebKit/public/platform/WebPushPermissionStatus.h"
 
 class GURL;
 
 namespace IPC {
 class Message;
 }  // namespace IPC
 
 namespace blink {
 class WebServiceWorkerProvider;
 }  // namespace blink
 
 namespace content {
 
 struct Manifest;
 
 class PushMessagingDispatcher : public RenderFrameObserver,
                                 public blink::WebPushClient {
  public:
   explicit PushMessagingDispatcher(RenderFrame* render_frame);
   virtual ~PushMessagingDispatcher();
 
  private:
   // RenderFrame::Observer implementation.
   bool OnMessageReceived(const IPC::Message& message) override;
 
   // WebPushClient implementation.
   virtual void registerPushMessaging(
       blink::WebPushRegistrationCallbacks* callbacks,
-      blink::WebServiceWorkerProvider* service_worker_provider);
-
+      blink::WebServiceWorkerProvider* service_worker_provider);  // override
+  virtual void getPermissionStatus(
+      blink::WebPushPermissionCallback* callback,
+      blink::WebServiceWorkerProvider* service_worker_provider);  // override
   void DoRegister(blink::WebPushRegistrationCallbacks* callbacks,

[mlamouri (slow - plz ping), 2014/10/29 20:13:33]

nit: leave an empty line between |getPermissionStatus()| and |DoRegister()| to
make it clearer that the latter isn't a WebPushClient implementation.

[Miguel Garcia, 2014/10/30 12:27:15]

Done.

                   blink::WebServiceWorkerProvider* service_worker_provider,
                   const Manifest& manifest);
 
   void OnRegisterSuccess(int32 callbacks_id,
                          const GURL& endpoint,
                          const std::string& registration_id);
 
   void OnRegisterError(int32 callbacks_id, PushRegistrationStatus status);
 
+  void OnPermissionStatus(int32 callback_id,
+                          blink::WebPushPermissionStatus status);
+  void OnPermissionStatusFailure(int32 callback_id);
+
   IDMap<blink::WebPushRegistrationCallbacks, IDMapOwnPointer>
       registration_callbacks_;
+  IDMap<blink::WebPushPermissionCallback, IDMapOwnPointer>
+      permission_check_callbacks_;
 
   DISALLOW_COPY_AND_ASSIGN(PushMessagingDispatcher);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_RENDERER_PUSH_MESSAGING_DISPATCHER_H_