Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(849)

Issue 661445: Avoid having every frame of a multipart response create a (Closed)

Created:
10 years, 9 months ago by tony
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Avoid having every frame of a multipart response create a new row in the history database. We do this by setting a flag on the WebURLResponse created for multipart responses and not updating the history db when this flag is set. BUG=34350 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=40599

Patch Set 1 #

Patch Set 2 : with unittest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -2 lines) Patch
M chrome/renderer/render_view.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webkit/glue/multipart_response_delegate.h View 1 chunk +3 lines, -0 lines 0 comments Download
M webkit/glue/multipart_response_delegate.cc View 2 chunks +8 lines, -1 line 0 comments Download
M webkit/glue/multipart_response_delegate_unittest.cc View 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tony
webkit side change coming up
10 years, 9 months ago (2010-03-03 04:40:47 UTC) #1
darin (slow to review)
LGTM but can you write a test for this?
10 years, 9 months ago (2010-03-03 06:14:15 UTC) #2
tony
On 2010/03/03 06:14:15, darin wrote: > LGTM but can you write a test for this? ...
10 years, 9 months ago (2010-03-03 07:30:54 UTC) #3
darin (slow to review)
10 years, 9 months ago (2010-03-03 08:28:40 UTC) #4
that test helps though.  thanks, LGTM

Powered by Google App Engine
This is Rietveld 408576698