Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 661433003: android_webview: explicitly use gcc for target binaries. (Closed)

Created:
6 years, 2 months ago by Torne
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

android_webview: explicitly use gcc for target binaries. To avoid causing problems for people working on using clang by default in AOSP, explicitly specify that the android webview build doesn't want to use clang for target binaries. The current default is false, so this doesn't change behaviour in the normal case. BUG= NOTRY=true Committed: https://crrev.com/6c1c44664f6b3cf7782142135be6206aeb356217 Cr-Commit-Position: refs/heads/master@{#299691}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M build/common.gypi View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Torne
6 years, 2 months ago (2014-10-15 14:33:48 UTC) #2
Primiano Tucci (use gerrit)
LGTM
6 years, 2 months ago (2014-10-15 15:53:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/661433003/1
6 years, 2 months ago (2014-10-15 15:55:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-15 15:56:07 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-15 15:56:46 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6c1c44664f6b3cf7782142135be6206aeb356217
Cr-Commit-Position: refs/heads/master@{#299691}

Powered by Google App Engine
This is Rietveld 408576698