Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Side by Side Diff: build/common.gypi

Issue 661433003: android_webview: explicitly use gcc for target binaries. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 5567 matching lines...) Expand 10 before | Expand all | Expand 10 after
5578 ['gcc_version>=48 and clang==0 and host_clang==1', { 5578 ['gcc_version>=48 and clang==0 and host_clang==1', {
5579 'target_defaults': { 5579 'target_defaults': {
5580 'target_conditions': [ 5580 'target_conditions': [
5581 ['_toolset=="host"', { 'cflags!': [ '-Wno-unused-local-typedefs' ]}], 5581 ['_toolset=="host"', { 'cflags!': [ '-Wno-unused-local-typedefs' ]}],
5582 ], 5582 ],
5583 }, 5583 },
5584 }], 5584 }],
5585 # In the android webview build, force host targets to be compiled with clang 5585 # In the android webview build, force host targets to be compiled with clang
5586 # as the hermetic host gcc is very old on some platforms. This is already 5586 # as the hermetic host gcc is very old on some platforms. This is already
5587 # the default on the current development version of AOSP but we force it 5587 # the default on the current development version of AOSP but we force it
5588 # here in case we need to compile against an older release version. 5588 # here in case we need to compile against an older release version. We also
5589 # explicitly set it to false for target binaries to avoid causing problems
5590 # for the work to enable clang by default in AOSP.
5589 ['android_webview_build==1', { 5591 ['android_webview_build==1', {
5590 'target_defaults': { 5592 'target_defaults': {
5591 'target_conditions': [ 5593 'target_conditions': [
5592 ['_toolset=="host"', { 5594 ['_toolset=="host"', {
5593 'aosp_build_settings': { 5595 'aosp_build_settings': {
5594 'LOCAL_CLANG': 'true', 5596 'LOCAL_CLANG': 'true',
5595 }, 5597 },
5598 }, { # else: _toolset != "host"
5599 'aosp_build_settings': {
5600 'LOCAL_CLANG': 'false',
5601 },
5596 }], 5602 }],
5597 ], 5603 ],
5598 }, 5604 },
5599 }], 5605 }],
5600 # We need a special case to handle the android webview build on mac because 5606 # We need a special case to handle the android webview build on mac because
5601 # the host gcc there doesn't accept this flag, but the target gcc may 5607 # the host gcc there doesn't accept this flag, but the target gcc may
5602 # require it. 5608 # require it.
5603 ['gcc_version>=48 and android_webview_build==1 and host_os=="mac"', { 5609 ['gcc_version>=48 and android_webview_build==1 and host_os=="mac"', {
5604 'target_defaults': { 5610 'target_defaults': {
5605 'target_conditions': [ 5611 'target_conditions': [
(...skipping 123 matching lines...) Expand 10 before | Expand all | Expand 10 after
5729 # settings in target dicts. SYMROOT is a special case, because many other 5735 # settings in target dicts. SYMROOT is a special case, because many other
5730 # Xcode variables depend on it, including variables such as 5736 # Xcode variables depend on it, including variables such as
5731 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 5737 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
5732 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 5738 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
5733 # files to appear (when present) in the UI as actual files and not red 5739 # files to appear (when present) in the UI as actual files and not red
5734 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 5740 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
5735 # and therefore SYMROOT, needs to be set at the project level. 5741 # and therefore SYMROOT, needs to be set at the project level.
5736 'SYMROOT': '<(DEPTH)/xcodebuild', 5742 'SYMROOT': '<(DEPTH)/xcodebuild',
5737 }, 5743 },
5738 } 5744 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698