chrome/browser/speech/extension_api/tts_extension_apitest.cc - Issue 661423008: Standardize usage of virtual/override/final in chrome/browser/speech

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/speech/extension_api/tts_extension_apitest.cc

Issue 661423008: Standardize usage of virtual/override/final in chrome/browser/speech (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/speech/extension_api/tts_extension_apitest.cc

diff --git a/chrome/browser/speech/extension_api/tts_extension_apitest.cc b/chrome/browser/speech/extension_api/tts_extension_apitest.cc

index 7a4003ea8e78a0f3c95452e527a98d97fe55349d..1dadbc508409beac5c1d21707396bc2ef238b9b0 100644

--- a/chrome/browser/speech/extension_api/tts_extension_apitest.cc

+++ b/chrome/browser/speech/extension_api/tts_extension_apitest.cc

@@ -169,9 +169,9 @@ class MockTtsPlatformImpl : public TtsPlatformImpl {

class FakeNetworkOnlineStateForTest : public net::NetworkChangeNotifier {

public:

explicit FakeNetworkOnlineStateForTest(bool online) : online_(online) {}

- virtual ~FakeNetworkOnlineStateForTest() {}

+ ~FakeNetworkOnlineStateForTest() override {}

- virtual ConnectionType GetCurrentConnectionType() const override {

+ ConnectionType GetCurrentConnectionType() const override {

return online_ ?

net::NetworkChangeNotifier::CONNECTION_ETHERNET :

net::NetworkChangeNotifier::CONNECTION_NONE;

« no previous file with comments | « chrome/browser/speech/extension_api/tts_extension_api.cc ('k') | chrome/browser/speech/tts_controller_impl.h » ('j') | no next file with comments »