chrome/browser/speech/extension_api/tts_extension_api.cc - Issue 661423008: Standardize usage of virtual/override/final in chrome/browser/speech

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/speech/extension_api/tts_extension_api.cc

Issue 661423008: Standardize usage of virtual/override/final in chrome/browser/speech (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/speech/extension_api/tts_extension_api.h ('k') | chrome/browser/speech/extension_api/tts_extension_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/speech/extension_api/tts_extension_api.cc

diff --git a/chrome/browser/speech/extension_api/tts_extension_api.cc b/chrome/browser/speech/extension_api/tts_extension_api.cc

index f2837efe59ca93357fdaaacdf515f481e8a10305..8633523fa6ffae976cbafb7cfdc39201ce8c6832 100644

--- a/chrome/browser/speech/extension_api/tts_extension_api.cc

+++ b/chrome/browser/speech/extension_api/tts_extension_api.cc

@@ -88,10 +88,10 @@ class TtsExtensionEventHandler

public:

explicit TtsExtensionEventHandler(const std::string& src_extension_id);

- virtual void OnTtsEvent(Utterance* utterance,

- TtsEventType event_type,

- int char_index,

- const std::string& error_message) override;

+ void OnTtsEvent(Utterance* utterance,

+ TtsEventType event_type,

+ int char_index,

+ const std::string& error_message) override;

private:

// The extension ID of the extension that called speak() and should