Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 661423002: DevTools: Clean-up service/shared workers code after switching to main thread debugging. (Closed)

Created:
6 years, 2 months ago by vsevik
Modified:
6 years, 2 months ago
Reviewers:
yurys, pfeldman, nasko, horo
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, horo+watch_chromium.org, jam, serviceworker-reviews, yurys, mkwst+moarreviews-ipc_chromium.org, paulirish+reviews_chromium.org, darin-cc_chromium.org, nhiroki, devtools-reviews_chromium.org, mkwst+moarreviews-renderer_chromium.org, kinuko+serviceworker, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

DevTools: Clean-up service/shared workers code after switching to main thread debugging. BUG=404355 Committed: https://crrev.com/bd519f338d4dd2acb800ac5b02dd1126015b84ff Cr-Commit-Position: refs/heads/master@{#300428}

Patch Set 1 #

Patch Set 2 : Removed some more code #

Messages

Total messages: 11 (2 generated)
vsevik
Please take a look. I am simply removing the code that is no longer used ...
6 years, 2 months ago (2014-10-20 09:29:21 UTC) #2
yurys
lgtm
6 years, 2 months ago (2014-10-20 10:36:10 UTC) #3
yurys
Is there a Blink patch removing WebSharedWorker::resumeWorkerContex ?
6 years, 2 months ago (2014-10-20 10:37:53 UTC) #4
vsevik
On 2014/10/20 10:37:53, yurys wrote: > Is there a Blink patch removing WebSharedWorker::resumeWorkerContex ? Sure, ...
6 years, 2 months ago (2014-10-20 11:24:09 UTC) #5
nasko
Code removal is always nice! LGTM
6 years, 2 months ago (2014-10-20 16:50:29 UTC) #6
horo
lgtm
6 years, 2 months ago (2014-10-21 00:22:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/661423002/20001
6 years, 2 months ago (2014-10-21 04:31:34 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-21 06:20:49 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 06:21:46 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bd519f338d4dd2acb800ac5b02dd1126015b84ff
Cr-Commit-Position: refs/heads/master@{#300428}

Powered by Google App Engine
This is Rietveld 408576698