Chromium Code Reviews
Help | Chromium Project | Sign in
(122)

Issue 661399: Merge 40426 - Fix a CHECK() being hit when the safebrowsing check times out (... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 1 month ago by eroman
Modified:
3 years, 10 months ago
Reviewers:
eroman, wtc
CC:
chromium-reviews, jam+cc_chromium.org, brettw+cc_chromium.org, Paul Godavari, darin-cc_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Merge 40426 - Fix a CHECK() being hit when the safebrowsing check times out (passing in empty URL but expecting the deferred URL). BUG=37195, 33572 TBR=wtc Review URL: http://codereview.chromium.org/660396 TBR=eroman@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=40437

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/browser/renderer_host/safe_browsing_resource_handler.cc View 2 chunks +3 lines, -2 lines 0 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 2 (0 generated)
eroman
5 years, 1 month ago (2010-03-02 21:39:53 UTC) #1
wtc
5 years, 1 month ago (2010-03-02 21:57:52 UTC) #2
LGTM.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cf4c24d