Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3366)

Unified Diff: chrome/browser/renderer_host/safe_browsing_resource_handler.cc

Issue 661399: Merge 40426 - Fix a CHECK() being hit when the safebrowsing check times out (... (Closed) Base URL: svn://svn.chromium.org/chrome/branches/342/src/
Patch Set: Created 10 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/renderer_host/safe_browsing_resource_handler.cc
===================================================================
--- chrome/browser/renderer_host/safe_browsing_resource_handler.cc (revision 40435)
+++ chrome/browser/renderer_host/safe_browsing_resource_handler.cc (working copy)
@@ -90,7 +90,7 @@
CHECK(state_ == STATE_CHECKING_URL);
CHECK(defer_state_ != DEFERRED_NONE);
safe_browsing_->CancelCheck(this);
- OnUrlCheckResult(GURL(), SafeBrowsingService::URL_SAFE);
+ OnUrlCheckResult(deferred_url_, SafeBrowsingService::URL_SAFE);
}
bool SafeBrowsingResourceHandler::OnWillStart(int request_id,
@@ -147,7 +147,8 @@
const GURL& url, SafeBrowsingService::UrlCheckResult result) {
CHECK(state_ == STATE_CHECKING_URL);
CHECK(defer_state_ != DEFERRED_NONE);
- CHECK(url == deferred_url_);
+ CHECK(url == deferred_url_) << "Was expecting: " << deferred_url_
+ << " but got: " << url;
timer_.Stop(); // Cancel the timeout timer.
safe_browsing_result_ = result;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698