Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issue 661353006: ozone: evdev: Dispatch events in task (Closed)

Created:
6 years, 2 months ago by spang
Modified:
6 years, 2 months ago
Reviewers:
kpschoedel
CC:
chromium-reviews, kalyank, tdresser+watch_chromium.org, ozone-reviews_chromium.org, hshi1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

ozone: evdev: Dispatch events in task This limits the amount of code that must be reentrant in the case of nested message loops. In particular libgestures is not reentrant; this fixes getting some modifiers stuck down with a context menu open. BUG=418787 TEST=manual on link_freon Committed: https://crrev.com/0abb227c87a36d12e52976466ea7f62f3945e8af Cr-Commit-Position: refs/heads/master@{#300488}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -88 lines) Patch
M ui/events/ozone/evdev/event_dispatch_callback.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/ozone/evdev/event_factory_evdev.h View 1 chunk +6 lines, -2 lines 0 comments Download
M ui/events/ozone/evdev/event_factory_evdev.cc View 3 chunks +16 lines, -10 lines 0 comments Download
M ui/events/ozone/evdev/key_event_converter_evdev_unittest.cc View 1 2 2 chunks +6 lines, -5 lines 0 comments Download
M ui/events/ozone/evdev/keyboard_evdev.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M ui/events/ozone/evdev/libgestures_glue/gesture_interpreter_libevdev_cros.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/ozone/evdev/libgestures_glue/gesture_interpreter_libevdev_cros.cc View 7 chunks +45 lines, -51 lines 0 comments Download
M ui/events/ozone/evdev/touch_event_converter_evdev.cc View 1 chunk +10 lines, -10 lines 0 comments Download
M ui/events/ozone/evdev/touch_event_converter_evdev_unittest.cc View 1 2 3 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
spang
6 years, 2 months ago (2014-10-20 18:44:39 UTC) #2
kpschoedel
lgtm
6 years, 2 months ago (2014-10-20 19:53:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/661353006/40001
6 years, 2 months ago (2014-10-21 14:16:50 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 2 months ago (2014-10-21 15:08:53 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 15:09:30 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0abb227c87a36d12e52976466ea7f62f3945e8af
Cr-Commit-Position: refs/heads/master@{#300488}

Powered by Google App Engine
This is Rietveld 408576698