Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Unified Diff: Source/core/inspector/ScriptArguments.cpp

Issue 661353005: Remove dead code in ScriptArguments. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: added const Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/inspector/ScriptArguments.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/inspector/ScriptArguments.cpp
diff --git a/Source/core/inspector/ScriptArguments.cpp b/Source/core/inspector/ScriptArguments.cpp
index ba3ba7bd05f4b4bf78f7d49e407412e49407b13e..c126dc7b79fe4624fb65874350ff9de6828a2f01 100644
--- a/Source/core/inspector/ScriptArguments.cpp
+++ b/Source/core/inspector/ScriptArguments.cpp
@@ -181,16 +181,13 @@ const ScriptValue &ScriptArguments::argumentAt(size_t index) const
return m_arguments[index];
}
-bool ScriptArguments::getFirstArgumentAsString(String& result, bool checkForNullOrUndefined)
+bool ScriptArguments::getFirstArgumentAsString(String& result) const
{
if (!argumentCount())
return false;
const ScriptValue& value = argumentAt(0);
ScriptState::Scope scope(m_scriptState.get());
- if (checkForNullOrUndefined && (value.isNull() || value.isUndefined()))
- return false;
-
result = V8ValueStringBuilder::toString(value.v8Value(), value.isolate());
return true;
}
« no previous file with comments | « Source/core/inspector/ScriptArguments.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698