Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Side by Side Diff: Source/core/inspector/ScriptArguments.cpp

Issue 661353005: Remove dead code in ScriptArguments. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: added const Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/inspector/ScriptArguments.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2010 Google Inc. All rights reserved. 2 * Copyright (c) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 163 matching lines...) Expand 10 before | Expand all | Expand 10 after
174 { 174 {
175 m_arguments.swap(arguments); 175 m_arguments.swap(arguments);
176 } 176 }
177 177
178 const ScriptValue &ScriptArguments::argumentAt(size_t index) const 178 const ScriptValue &ScriptArguments::argumentAt(size_t index) const
179 { 179 {
180 ASSERT(m_arguments.size() > index); 180 ASSERT(m_arguments.size() > index);
181 return m_arguments[index]; 181 return m_arguments[index];
182 } 182 }
183 183
184 bool ScriptArguments::getFirstArgumentAsString(String& result, bool checkForNull OrUndefined) 184 bool ScriptArguments::getFirstArgumentAsString(String& result) const
185 { 185 {
186 if (!argumentCount()) 186 if (!argumentCount())
187 return false; 187 return false;
188 188
189 const ScriptValue& value = argumentAt(0); 189 const ScriptValue& value = argumentAt(0);
190 ScriptState::Scope scope(m_scriptState.get()); 190 ScriptState::Scope scope(m_scriptState.get());
191 if (checkForNullOrUndefined && (value.isNull() || value.isUndefined()))
192 return false;
193
194 result = V8ValueStringBuilder::toString(value.v8Value(), value.isolate()); 191 result = V8ValueStringBuilder::toString(value.v8Value(), value.isolate());
195 return true; 192 return true;
196 } 193 }
197 194
198 } // namespace blink 195 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/inspector/ScriptArguments.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698