Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(715)

Issue 661303002: Revert of [Telemetry] Set the number of attempts to retry a test if browser or tab crash to 1 (Closed)

Created:
6 years, 2 months ago by hendrikw
Modified:
6 years, 2 months ago
Reviewers:
nednguyen, dtu, tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of [Telemetry] Set the number of attempts to retry a test if browser or tab crash to 1 (patchset #2 id:20001 of https://codereview.chromium.org/659753003/) Reason for revert: Possible cause of gpu telemetry bot flake Original issue's description: > [Telemetry] Set the number of attempts to retry a test to 1 > > **SHERIFFS: if telemetry perf tests on waterfall become more flaky, this patch can be safely reverted. > > BUG=422339 > > Committed: https://crrev.com/f5b75f261be7779ccca14d09ddaabb3e4ee5ee03 > Cr-Commit-Position: refs/heads/master@{#299716} TBR=tonyg@chromium.org,dtu@chromium.org,nednguyen@google.com NOTREECHECKS=true NOTRY=true BUG=422339 Committed: https://crrev.com/1c141bedc45cdef1ac7b7264ea1288c33e33d106 Cr-Commit-Position: refs/heads/master@{#300218}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M tools/telemetry/telemetry/page/page_runner_unittest.py View 1 chunk +0 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/page/page_test.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
hendrikw
Created Revert of [Telemetry] Set the number of attempts to retry a test if browser ...
6 years, 2 months ago (2014-10-18 19:58:52 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/661303002/1
6 years, 2 months ago (2014-10-18 20:00:19 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 2 months ago (2014-10-18 20:00:21 UTC) #4
nednguyen
On 2014/10/18 20:00:21, I haz the power (commit-bot) wrote: > No LGTM from a valid ...
6 years, 2 months ago (2014-10-18 21:28:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/661303002/1
6 years, 2 months ago (2014-10-18 21:28:51 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-18 21:29:35 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1c141bedc45cdef1ac7b7264ea1288c33e33d106 Cr-Commit-Position: refs/heads/master@{#300218}
6 years, 2 months ago (2014-10-18 21:30:19 UTC) #9
Ken Russell (switch to Gerrit)
6 years, 2 months ago (2014-10-19 14:30:43 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/662963002/ by kbr@chromium.org.

The reason for reverting is: The removal of Telemetry's retry logic wasn't the
cause of the intermittent crashes on the GPU bots.
.

Powered by Google App Engine
This is Rietveld 408576698